[NPM-3754] Add config to enable traceroute in sysprobe #1744
+15
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
chart/datadog
brycekahle
reviewed
Mar 6, 2025
| @@ -66,6 +66,10 @@ data: | |||
| native: | |||
| enabled: {{ $.Values.datadog.serviceMonitoring.tls.native.enabled }} | |||
| {{- end }} | |||
| {{- if not (eq .Values.datadog.traceroute.enabled nil) }} | |||
There was a problem hiding this comment.
I don't think you need to guard with the not-nil check.
brycekahle
approved these changes
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds a config flag to enable the
traceroutemodule in system-probe.Which issue this PR fixes
This PR makes it possible to enable Network Path with the helm charts.
Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
.github/helm-docs.sh)CHANGELOG.mdhas been updatedREADME.mddatadogordatadog-operatorchart or value changes, update the test baselines (run:make update-test-baselines)