Skip to content

Commit

Permalink
Added option, but rbac is not updating properly
Browse files Browse the repository at this point in the history
  • Loading branch information
ewoodthomas committed Mar 7, 2025
1 parent 7ee6d21 commit e83816b
Show file tree
Hide file tree
Showing 5 changed files with 22 additions and 1 deletion.
5 changes: 5 additions & 0 deletions charts/datadog/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
# Datadog changelog

## 3.106.1

* Add `pods` to the list of resources to collect in the Agent RBAC when `datadog.kubelet.useApiServer` is set to `true`.
* Add configuration option for `datadog.kubelet.useApiServer` to get the pod list from the API Server instead of the Kubelet. Disabled by default.

## 3.106.0

* Target based workload selection for Single Step Instrumentation has been added in preview (requires Cluster Agent 7.64.0+)
Expand Down
2 changes: 1 addition & 1 deletion charts/datadog/Chart.yaml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
---
apiVersion: v1
name: datadog
version: 3.106.0
version: 3.106.1
appVersion: "7"
description: Datadog Agent
keywords:
Expand Down
4 changes: 4 additions & 0 deletions charts/datadog/templates/_containers-common-env.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,10 @@
- name: DD_KUBELET_TLS_VERIFY
value: {{ .Values.datadog.kubelet.tlsVerify | quote }}
{{- end }}
{{- if .Values.datadog.kubelet.useApiServer | quote }}
- name: DD_KUBELET_USE_API_SERVER
value: {{ .Values.datadog.kubelet.useApiServer | quote }}
{{- end }}
{{- if ne (include "datadog.kubelet.mountPath" .) "" }}
- name: DD_KUBELET_CLIENT_CA
value: {{ include "datadog.kubelet.mountPath" . }}
Expand Down
9 changes: 9 additions & 0 deletions charts/datadog/templates/rbac.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,15 @@ rules:
verbs:
- get
- list
{{- if .Values.datadog.kubelet.useApiServer }}
- apiGroups:
- ""
resources:
- pods
verbs:
- get
- list
{{- end }}
{{- if .Values.datadog.collectEvents }}
- apiGroups:
- ""
Expand Down
3 changes: 3 additions & 0 deletions charts/datadog/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -316,6 +316,9 @@ datadog:
# datadog.kubelet.podResourcesSocketDir -- Path (on host) where the kubelet.sock socket for the PodResources API is located
# @default -- /var/lib/kubelet/pod-resources
podResourcesSocketDir: /var/lib/kubelet/pod-resources
# datadog.kubelet.useApiServer -- Enable this to query the pod list from the API Server instead of the Kubelet
# @default -- false
useApiServer: true


# datadog.expvarPort -- Specify the port to expose pprof and expvar to not interfere with the agent metrics port from the cluster-agent, which defaults to 5000
Expand Down

0 comments on commit e83816b

Please sign in to comment.