Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DatadogAgent v1alpha1 deprecation warning #22010

Merged
merged 2 commits into from
Mar 1, 2024

Conversation

levan-m
Copy link
Contributor

@levan-m levan-m commented Feb 29, 2024

What does this PR do? What is the motivation?

Adds a deprecation warning for DatadogAgent v1alpha1 version, similar warning was added to helm charts and the binary
DataDog/helm-charts#1332
DataDog/datadog-operator#1099

Merge instructions

  • Please merge after reviewing

Additional notes

@levan-m levan-m requested a review from a team as a code owner February 29, 2024 21:08
@github-actions github-actions bot added the Guide Content impacting a guide label Feb 29, 2024
Copy link
Contributor

Preview links (active after the build_preview check completes)

Modified Files

Copy link
Contributor

@drichards-87 drichards-87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left you some minor feedback.

Co-authored-by: DeForest Richards <56796055+drichards-87@users.noreply.github.com>
@levan-m levan-m requested a review from drichards-87 March 1, 2024 02:41
Copy link
Contributor

@drichards-87 drichards-87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@levan-m Looks good. Is this ready to be merged?

@levan-m
Copy link
Contributor Author

levan-m commented Mar 1, 2024

Thank you! Yes, you can merge it.

@drichards-87 drichards-87 merged commit 0ed1a6d into master Mar 1, 2024
13 checks passed
@drichards-87 drichards-87 deleted the levan-m/v1alpha1-deprecation-notice branch March 1, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Guide Content impacting a guide
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants