Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use non-large arm runner for Nix #4420

Merged
merged 1 commit into from
Feb 21, 2025
Merged

Conversation

lloeki
Copy link
Member

@lloeki lloeki commented Feb 21, 2025

What does this PR do?

Use ubuntu-24.04-arm.

Motivation:

As visible in repo Insights Actions Usage Metrics the arm-4core-linux-ubuntu24.04 variant is a hosted-larger which may not be free.

Change log entry

None.

Additional Notes:

See: https://github.blog/changelog/2025-01-16-linux-arm64-hosted-runners-now-available-for-free-in-public-repositories-public-preview/

Parametric tests would be the last one using a hosted-larged runner type:

https://github.com/DataDog/system-tests/blob/abb550d5ea74ff1cc4c9f455bb18dc0fa085e1d4/.github/workflows/run-parametric.yml#L46-L48

To get control over runs-on: it would need a change like:

on:
  workflow_call:
    inputs:
      runs_on:
        description: "Runner definition"
        default: '{ "group": "APM Larger Runners" }'
        required: false
        type: string

jobs:
  parametric:
    runs-on: ${{ fromJson( inputs.runs_on ) }}

Then a change here:

parametric:
needs:
- build-artifacts
- changes
if: ${{ needs.changes.outputs.changes == 'true' }}
uses: DataDog/system-tests/.github/workflows/run-parametric.yml@main
secrets: inherit
with:
library: ruby
binaries_artifact: system_tests_binaries
job_count: 8
job_matrix: "[1,2,3,4,5,6,7,8]"

to:

  parametric:
    with:
      library: ruby
      binaries_artifact: system_tests_binaries
      job_count: 16
      job_matrix: "[1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16]"
      runs_on: "ubuntu-24.04"

How to test the change?

  • CI should pass
  • Insights should report hosted instead of hosted-larger.

@github-actions github-actions bot added the dev/github Github repository maintenance and automation label Feb 21, 2025
@lloeki lloeki force-pushed the lloeki/use-non-large-arm-runner branch from 65ae8d9 to a7faad2 Compare February 21, 2025 08:42
@datadog-datadog-prod-us1
Copy link
Contributor

datadog-datadog-prod-us1 bot commented Feb 21, 2025

Datadog Report

Branch report: lloeki/use-non-large-arm-runner
Commit report: 81d1ffa
Test service: dd-trace-rb

✅ 0 Failed, 20604 Passed, 1374 Skipped, 3m 13.61s Total Time

@pr-commenter
Copy link

pr-commenter bot commented Feb 21, 2025

Benchmarks

Benchmark execution time: 2025-02-21 11:12:14

Comparing candidate commit 81d1ffa in PR branch lloeki/use-non-large-arm-runner with baseline commit 29a6bd8 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 31 metrics, 2 unstable metrics.

@lloeki lloeki marked this pull request as ready for review February 21, 2025 09:41
@lloeki lloeki requested a review from a team as a code owner February 21, 2025 09:41
As visible in repo `Insights` `Actions Usage Metrics` the
`arm-4core-linux-ubuntu24.04` variant is a `hosted-larger` which may not
be free.

Use `ubuntu-24.04-arm` instead.

See: https://github.blog/changelog/2025-01-16-linux-arm64-hosted-runners-now-available-for-free-in-public-repositories-public-preview/
@lloeki lloeki force-pushed the lloeki/use-non-large-arm-runner branch from a7faad2 to 81d1ffa Compare February 21, 2025 10:48
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.72%. Comparing base (29a6bd8) to head (81d1ffa).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4420   +/-   ##
=======================================
  Coverage   97.72%   97.72%           
=======================================
  Files        1365     1365           
  Lines       83337    83336    -1     
  Branches     4219     4219           
=======================================
+ Hits        81440    81444    +4     
+ Misses       1897     1892    -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lloeki lloeki enabled auto-merge February 21, 2025 11:28
@lloeki lloeki merged commit 0e4b45c into master Feb 21, 2025
499 checks passed
@lloeki lloeki deleted the lloeki/use-non-large-arm-runner branch February 21, 2025 11:54
@github-actions github-actions bot added this to the 2.11.0 milestone Feb 21, 2025
@lloeki lloeki changed the title Use non-large arm runner Use non-large arm runner for Nix Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev/github Github repository maintenance and automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants