Fix cross-repo race condition #4404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should be reverted after the corresponding branch on DataDog/vaccine is merged.
This narrows down the triggered workflow run to the exact one created by the GitLab CI pipeline. A number of corner cases were improperly handled, and there was an opportunity for a secret leak, which led to a full script rewrite.
BenchmarksBenchmark execution time: 2025-02-19 10:15:39 Comparing candidate commit ca2935b in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 33 metrics, 2 unstable metrics. |
TonyCTHsu
approved these changes
Feb 19, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4404 +/- ##
=======================================
Coverage 97.70% 97.70%
=======================================
Files 1366 1366
Lines 83372 83373 +1
Branches 4230 4230
=======================================
+ Hits 81462 81463 +1
Misses 1910 1910 ☔ View full report in Codecov by Sentry. |
Datadog ReportBranch report: ✅ 0 Failed, 20596 Passed, 1372 Skipped, 3m 18.5s Total Time |
This reverts commit e216ea9.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Motivation:
Given that we run across repos and across CIs, there was a significant probability to pick incorrect workflows, that would be entirely unrelated to the
dd-trace-rbitem that triggered a workflow here.On the
vaccineside this is addressed by:trigger-idinputtrigger-idin the workflow run nameAs a bonus this allows direct identification of
vaccineworkflow runs straight from GitHub Actions UI.The image is pulled by
vaccineby tag containing only the commit SHA and so remains vulnerable to race conditions.Change log entry
None.
Additional Notes:
Use lloeki/fix-cross-repo-race-condition branch temporarily must be reverted once that sister PR is merged on
DataDog/vaccine.shellchecked locally, but this linting should probably be enforced in CI.How to test the change?
CI should pick the proper things throughout. Check
Vaccinejob logs in GitLab pipeline, e.g https://gitlab.ddbuild.io/DataDog/apm-reliability/dd-trace-rb/-/jobs/813418074 and https://github.com/DataDog/vaccine/actions/runs/13409446292