Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test sidekiq specs #4392

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

Conversation

sarahchen6
Copy link
Contributor

@sarahchen6 sarahchen6 commented Feb 14, 2025

What does this PR do?
Attempt to address the flaky sidekiq tests that fail with Connection refused - connect(2) for 127.0.0.1:6379 (Errno::ECONNREFUSED) by forcing a redis host over localhost. Did not work though.

Motivation:
Reduce CI flakiness, and re-enable our GHA specs (issue)!

Change log entry
None.

Additional Notes:
Issue: https://github.com/DataDog/ruby-guild/issues/51.

How to test the change?
Consistently green CI.

Copy link

github-actions bot commented Feb 14, 2025

Thank you for updating Change log entry section 👏

Visited at: 2025-02-14 20:23:46 UTC

@datadog-datadog-prod-us1
Copy link
Contributor

datadog-datadog-prod-us1 bot commented Feb 14, 2025

Datadog Report

Branch report: sarahchen6/experiment-with-sidekiq
Commit report: 3f56051
Test service: dd-trace-rb

✅ 0 Failed, 22372 Passed, 1387 Skipped, 3m 12.79s Total Time

@codecov-commenter
Copy link

codecov-commenter commented Feb 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.74%. Comparing base (887e26d) to head (3f56051).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4392      +/-   ##
==========================================
+ Coverage   97.71%   97.74%   +0.03%     
==========================================
  Files        1353     1353              
  Lines       82925    82975      +50     
  Branches     4209     4213       +4     
==========================================
+ Hits        81028    81102      +74     
+ Misses       1897     1873      -24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pr-commenter
Copy link

pr-commenter bot commented Feb 14, 2025

Benchmarks

Benchmark execution time: 2025-02-14 20:48:10

Comparing candidate commit 3f56051 in PR branch sarahchen6/experiment-with-sidekiq with baseline commit 887e26d in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 31 metrics, 2 unstable metrics.

@sarahchen6 sarahchen6 force-pushed the sarahchen6/experiment-with-sidekiq branch from 43d04be to 9096762 Compare February 14, 2025 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants