-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test sidekiq specs #4392
base: master
Are you sure you want to change the base?
Test sidekiq specs #4392
Conversation
Thank you for updating Change log entry section 👏 Visited at: 2025-02-14 20:23:46 UTC |
Datadog ReportBranch report: ✅ 0 Failed, 22372 Passed, 1387 Skipped, 3m 12.79s Total Time |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4392 +/- ##
==========================================
+ Coverage 97.71% 97.74% +0.03%
==========================================
Files 1353 1353
Lines 82925 82975 +50
Branches 4209 4213 +4
==========================================
+ Hits 81028 81102 +74
+ Misses 1897 1873 -24 ☔ View full report in Codecov by Sentry. |
BenchmarksBenchmark execution time: 2025-02-14 20:48:10 Comparing candidate commit 3f56051 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 31 metrics, 2 unstable metrics. |
43d04be
to
9096762
Compare
What does this PR do?
Attempt to address the flaky
sidekiq
tests that fail withConnection refused - connect(2) for 127.0.0.1:6379 (Errno::ECONNREFUSED)
by forcing aredis
host overlocalhost
. Did not work though.Motivation:
Reduce CI flakiness, and re-enable our GHA specs (issue)!
Change log entry
None.
Additional Notes:
Issue: https://github.com/DataDog/ruby-guild/issues/51.
How to test the change?
Consistently green CI.