Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cache clean permission with actions: write #4389

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

TonyCTHsu
Copy link
Contributor

What does this PR do?

Update cache clean permission with actions: write

Change log entry

None.

@TonyCTHsu TonyCTHsu added the dev/github Github repository maintenance and automation label Feb 14, 2025
@TonyCTHsu TonyCTHsu marked this pull request as ready for review February 14, 2025 10:18
@TonyCTHsu TonyCTHsu requested a review from a team as a code owner February 14, 2025 10:18
@TonyCTHsu TonyCTHsu enabled auto-merge February 14, 2025 10:18
@datadog-datadog-prod-us1
Copy link
Contributor

Datadog Report

Branch report: tonycthsu/cache-clean-permission
Commit report: 53b1d55
Test service: dd-trace-rb

✅ 0 Failed, 20103 Passed, 1449 Skipped, 3m 16.67s Total Time

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.69%. Comparing base (95f139c) to head (53b1d55).
Report is 5 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4389   +/-   ##
=======================================
  Coverage   97.69%   97.69%           
=======================================
  Files        1352     1352           
  Lines       82734    82735    +1     
  Branches     4200     4200           
=======================================
+ Hits        80824    80825    +1     
  Misses       1910     1910           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pr-commenter
Copy link

pr-commenter bot commented Feb 14, 2025

Benchmarks

Benchmark execution time: 2025-02-14 10:31:00

Comparing candidate commit 53b1d55 in PR branch tonycthsu/cache-clean-permission with baseline commit 95f139c in branch master.

Found 3 performance improvements and 0 performance regressions! Performance is the same for 28 metrics, 2 unstable metrics.

scenario:profiler - sample timeline=false

  • 🟩 throughput [+0.503op/s; +0.511op/s] or [+8.455%; +8.593%]

scenario:tracing - Propagation - Datadog

  • 🟩 throughput [+3561.056op/s; +3635.719op/s] or [+11.977%; +12.228%]

scenario:tracing - Tracing.log_correlation

  • 🟩 throughput [+8088.838op/s; +8430.121op/s] or [+7.324%; +7.633%]

@TonyCTHsu TonyCTHsu merged commit c84a54a into master Feb 14, 2025
492 checks passed
@TonyCTHsu TonyCTHsu deleted the tonycthsu/cache-clean-permission branch February 14, 2025 10:38
@github-actions github-actions bot added this to the 2.11.0 milestone Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev/github Github repository maintenance and automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants