Add Ruby 3.4.0-preview2 support for integration apps #4038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksBenchmark execution time: 2024-10-28 18:07:17 Comparing candidate commit d8d2303 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 24 metrics, 2 unstable metrics. |
marcotc
approved these changes
Oct 28, 2024
This was referenced Oct 28, 2024
Closed
This was referenced Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds Ruby 3.4.0-preview2 support for integration apps. The PR adds a "3.4" version to every file under
integrationthat needs to be modified to provide support (indicated with "ADD NEW RUBIES HERE").Motivation:
Though the official Ruby 3.4 is not yet released, we can temporarily add Ruby 3.4.0-preview2. This allows us to start testing with Ruby 3.4 in our CI and spot -> address issues early. After Ruby 3.4 is officially released post-Dec 25, 2024, we can replace the preview with it.
Change log entry
No change log entry for now. Thinking to have a "Ruby 3.4.0-preview2 support added" update after it is fully supported.
Additional Notes:
More Ruby 3.4.0-preview2 support is needed. This PR is one step toward full support and only addresses integration apps.
How to test the change?
This change can be tested in CI.