Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(iast): more sqli redaction tests #12242

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

avara1986
Copy link
Member

@avara1986 avara1986 commented Feb 6, 2025

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@avara1986 avara1986 added changelog/no-changelog A changelog entry is not required for this PR. ASM Application Security Monitoring labels Feb 6, 2025
Copy link
Contributor

github-actions bot commented Feb 6, 2025

CODEOWNERS have been resolved as:

tests/appsec/integrations/django_tests/conftest.py                      @DataDog/asm-python
tests/appsec/integrations/django_tests/django_app/urls.py               @DataDog/asm-python
tests/appsec/integrations/django_tests/django_app/views.py              @DataDog/asm-python
tests/appsec/integrations/django_tests/test_django_appsec_iast.py       @DataDog/asm-python

@datadog-dd-trace-py-rkomorn
Copy link

Datadog Report

Branch report: avara1986/more_sqli_redaction_tests
Commit report: 2b56d90
Test service: dd-trace-py

✅ 0 Failed, 130 Passed, 1184 Skipped, 3m 30.3s Total duration (25m 24.43s time saved)

@avara1986 avara1986 marked this pull request as ready for review February 6, 2025 15:01
@avara1986 avara1986 requested a review from a team as a code owner February 6, 2025 15:01
@avara1986 avara1986 force-pushed the avara1986/more_sqli_redaction_tests branch from 2b56d90 to f2a162e Compare February 7, 2025 07:42
@avara1986 avara1986 removed request for a team February 7, 2025 07:42
@pr-commenter
Copy link

pr-commenter bot commented Feb 7, 2025

Benchmarks

Benchmark execution time: 2025-02-07 08:24:51

Comparing candidate commit f2a162e in PR branch avara1986/more_sqli_redaction_tests with baseline commit 1247ac2 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 394 metrics, 2 unstable metrics.

@avara1986 avara1986 merged commit 9d4d417 into main Feb 7, 2025
318 checks passed
@avara1986 avara1986 deleted the avara1986/more_sqli_redaction_tests branch February 7, 2025 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ASM Application Security Monitoring changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants