chore(pin): prevent overriding the global tracer #12219
Draft
+205
−179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![datadog-datadog-prod-us1[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
| pin = Pin(service, tags=tags) | ||
| else: | ||
| pin = Pin(service, tags=tags, tracer=pin.tracer) | ||
| pin = Pin(service, tags=tags) |
There was a problem hiding this comment.
🟠 Code Quality Violation
variable name is the same as a function parameter (...read more)
A function parameter should only be read and not be modified. If your intent is to modify the value of the parameter, return the value in the function and handle the new value in the caller of the function.
|
|
mabdinur
force-pushed
the
munir/remove-deprecations-from-pin
branch
from
20d6173 to
ddf975c
Compare
Datadog ReportBranch report: ❌ 103 Failed (0 Known Flaky), 472 Passed, 305 Skipped, 9m 22.22s Total duration (11m 22.76s time saved) ❌ Failed Tests (103)
|
BenchmarksBenchmark execution time: 2025-02-04 21:03:04 Comparing candidate commit d3624a0 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 394 metrics, 2 unstable metrics. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Reviewer Checklist