Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(openai): remove remaining v0 snapshot files #12218

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

Yun-Kim
Copy link
Contributor

@Yun-Kim Yun-Kim commented Feb 4, 2025

Removes unused snapshots from now-removed v0 tests.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@Yun-Kim Yun-Kim added the changelog/no-changelog A changelog entry is not required for this PR. label Feb 4, 2025
@Yun-Kim Yun-Kim requested a review from a team as a code owner February 4, 2025 16:36
@Yun-Kim Yun-Kim requested review from sanchda and nsrip-dd February 4, 2025 16:36
@datadog-dd-trace-py-rkomorn
Copy link

Datadog Report

Branch report: yunkim/openai-drop-v0-tests
Commit report: 3cade0d
Test service: dd-trace-py

✅ 0 Failed, 130 Passed, 1184 Skipped, 3m 16.53s Total duration (24m 51.43s time saved)

@pr-commenter
Copy link

pr-commenter bot commented Feb 4, 2025

Benchmarks

Benchmark execution time: 2025-02-04 17:17:36

Comparing candidate commit 3cade0d in PR branch yunkim/openai-drop-v0-tests with baseline commit 2ccaaef in branch 3.x-staging.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 394 metrics, 2 unstable metrics.

@Yun-Kim Yun-Kim merged commit 3ac7025 into 3.x-staging Feb 4, 2025
286 of 287 checks passed
@Yun-Kim Yun-Kim deleted the yunkim/openai-drop-v0-tests branch February 4, 2025 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants