Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(benchmarks): fix failing microbenchmarks #12217

Merged

Conversation

mabdinur
Copy link
Contributor

@mabdinur mabdinur commented Feb 4, 2025

#12186 removed deprecated parameters from tracer.configure(...) and rate_limiter.allowed(...) but did not update the microbenchmarks. This PR address this issue.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@mabdinur mabdinur requested a review from a team as a code owner February 4, 2025 15:18
@mabdinur mabdinur requested a review from emmettbutler February 4, 2025 15:18
@mabdinur mabdinur changed the title chore( ci(benchmarks): fix failing microbenchmarks Feb 4, 2025
Copy link
Contributor

github-actions bot commented Feb 4, 2025

CODEOWNERS have been resolved as:

benchmarks/bm/utils.py                                                  @DataDog/apm-core-python
benchmarks/rate_limiter/scenario.py                                     @DataDog/apm-core-python

@mabdinur mabdinur force-pushed the munir/fix-microbenchmarks branch from 6f1e40c to 5ac12b1 Compare February 4, 2025 15:27
@datadog-dd-trace-py-rkomorn
Copy link

Datadog Report

Branch report: munir/fix-microbenchmarks
Commit report: 6f1e40c
Test service: dd-trace-py

✅ 0 Failed, 130 Passed, 1184 Skipped, 3m 50.79s Total duration (24m 51.83s time saved)

@mabdinur mabdinur added the changelog/no-changelog A changelog entry is not required for this PR. label Feb 4, 2025
@mabdinur mabdinur changed the base branch from 3.x-staging to munir/remove-more-deprecated-code February 4, 2025 15:41
@mabdinur mabdinur merged commit 514f5f2 into munir/remove-more-deprecated-code Feb 4, 2025
136 of 153 checks passed
@mabdinur mabdinur deleted the munir/fix-microbenchmarks branch February 4, 2025 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant