-
Notifications
You must be signed in to change notification settings - Fork 424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(asm): don't load appsec modules (iast) if disabled #12184
chore(asm): don't load appsec modules (iast) if disabled #12184
Conversation
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 3.x-staging #12184 +/- ##
==============================================
Coverage ? 12.74%
==============================================
Files ? 1606
Lines ? 135677
Branches ? 0
==============================================
Hits ? 17298
Misses ? 118379
Partials ? 0 ☔ View full report in Codecov by Sentry. |
Datadog ReportBranch report: ✅ 0 Failed, 130 Passed, 1468 Skipped, 4m 41.04s Total duration (35m 44.47s time saved) |
…endencies_if_serverless
…endencies_if_serverless
BenchmarksBenchmark execution time: 2025-02-03 14:47:27 Comparing candidate commit 484dae9 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 394 metrics, 2 unstable metrics. |
a2fc25e
to
9271c33
Compare
…azian/remove_appsec_dependencies_if_serverless
…endencies_if_serverless
…rless' of github.com:DataDog/dd-trace-py into christophe-papazian/remove_appsec_dependencies_if_serverless
…endencies_if_serverless
…endencies_if_serverless
The goal is to make sure no appsec module is loaded if appsec is disabled.
This PR is the first one of 2, handling IAST.
It removes all non guarded IAST import from outside appsec.
_is_iast_enabled()
by a field_iast_enabled
in the asm configAPPSEC-56626
Checklist
strategy
guidelines
applicable)
Reviewer Checklist
API
changes
implications of this PR as reported in the benchmarks PR comment
release branch maintenance
policy