Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(configurations): remove deprecated tracing env vars #12176

Open
wants to merge 8 commits into
base: 3.x-staging
Choose a base branch
from

Conversation

mabdinur
Copy link
Contributor

@mabdinur mabdinur commented Jan 30, 2025

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

Copy link
Contributor

github-actions bot commented Jan 30, 2025

CODEOWNERS have been resolved as:

releasenotes/notes/remove-deprecated-tracing-configs-c6711b57037576f6.yaml  @DataDog/apm-python
ddtrace/settings/_config.py                                             @DataDog/apm-core-python
ddtrace/settings/_otel_remapper.py                                      @DataDog/apm-core-python
docs/configuration.rst                                                  @DataDog/python-guild
tests/appsec/iast/test_processor.py                                     @DataDog/asm-python
tests/integration/test_settings.py                                      @DataDog/apm-core-python
tests/internal/test_settings.py                                         @DataDog/apm-core-python
tests/opentelemetry/test_config.py                                      @DataDog/apm-sdk-api-python
tests/suitespec.yml                                                     @DataDog/python-guild @DataDog/apm-core-python
tests/telemetry/test_writer.py                                          @DataDog/apm-python
tests/tracer/test_encoders.py                                           @DataDog/apm-sdk-api-python
tests/tracer/test_sampler.py                                            @DataDog/apm-sdk-api-python

)

# Disabling DD_TRACE_128_BIT_TRACEID_LOGGING_ENABLED is not supported. Remove this configuration in the future.
self._128_bit_trace_id_logging_enabled = True
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc: @mtoffl01

Not sure if we should pull this out into it's own PR. DD_TRACE_128_BIT_TRACEID_LOGGING_ENABLED configuration is being removed so we need to enable this functionality by default.

Maybe this could use it's own release note.

@mabdinur mabdinur requested a review from mtoffl01 January 30, 2025 17:58
@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Jan 30, 2025

Datadog Report

Branch report: munir/remove-deprecated-tracing-configs
Commit report: 81e0b95
Test service: dd-trace-py

✅ 0 Failed, 130 Passed, 1468 Skipped, 5m 6.89s Total duration (35m 38.92s time saved)

category=DDTraceDeprecationWarning,
)
# DD_ANALYTICS_ENABLED is not longer supported, remove this functionatiy from all integrations in the future
self._analytics_enabled = False
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to the changes above, should we log that analytics_enabled is not supported?

@pr-commenter
Copy link

pr-commenter bot commented Jan 30, 2025

Benchmarks

Benchmark execution time: 2025-01-31 03:17:29

Comparing candidate commit 81e0b95 in PR branch munir/remove-deprecated-tracing-configs with baseline commit 0ed084a in branch 3.x-staging.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 394 metrics, 2 unstable metrics.

@mabdinur mabdinur requested a review from a team as a code owner January 30, 2025 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants