-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(configurations): remove deprecated tracing env vars #12176
base: 3.x-staging
Are you sure you want to change the base?
Conversation
|
) | ||
|
||
# Disabling DD_TRACE_128_BIT_TRACEID_LOGGING_ENABLED is not supported. Remove this configuration in the future. | ||
self._128_bit_trace_id_logging_enabled = True |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc: @mtoffl01
Not sure if we should pull this out into it's own PR. DD_TRACE_128_BIT_TRACEID_LOGGING_ENABLED
configuration is being removed so we need to enable this functionality by default.
Maybe this could use it's own release note.
Datadog ReportBranch report: ✅ 0 Failed, 130 Passed, 1468 Skipped, 5m 6.89s Total duration (35m 38.92s time saved) |
category=DDTraceDeprecationWarning, | ||
) | ||
# DD_ANALYTICS_ENABLED is not longer supported, remove this functionatiy from all integrations in the future | ||
self._analytics_enabled = False |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar to the changes above, should we log that analytics_enabled is not supported?
BenchmarksBenchmark execution time: 2025-01-31 03:17:29 Comparing candidate commit 81e0b95 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 394 metrics, 2 unstable metrics. |
Checklist
Reviewer Checklist