Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(iast): add support for pymysql, mysqldb integrations #12127

Merged
merged 21 commits into from
Feb 3, 2025

Conversation

gnufede
Copy link
Member

@gnufede gnufede commented Jan 28, 2025

Code Security: Adds IAST support to pymysql and mysqldb integrations

APPSEC-56500

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

Copy link
Contributor

CODEOWNERS have been resolved as:

.riot/requirements/106990f.txt                                          @DataDog/apm-python
.riot/requirements/1140d28.txt                                          @DataDog/apm-python
.riot/requirements/1568a2f.txt                                          @DataDog/apm-python
.riot/requirements/16a770c.txt                                          @DataDog/apm-python
.riot/requirements/8fd54b8.txt                                          @DataDog/apm-python
releasenotes/notes/feat-iast-pymysql-support-d7f79f0355bb85d1.yaml      @DataDog/apm-python
tests/appsec/iast/fixtures/taint_sinks/sql_injection_mysqldb.py         @DataDog/asm-python
tests/appsec/iast/fixtures/taint_sinks/sql_injection_pymysql.py         @DataDog/asm-python
.gitlab/services.yml                                                    @DataDog/python-guild @DataDog/apm-core-python
ddtrace/appsec/_iast/_evidence_redaction/sql_sensitive_analyzer.py      @DataDog/asm-python
ddtrace/appsec/_iast/constants.py                                       @DataDog/asm-python
riotfile.py                                                             @DataDog/apm-python
tests/appsec/iast/taint_sinks/test_sql_injection.py                     @DataDog/asm-python
tests/appsec/suitespec.yml                                              @DataDog/asm-python
.riot/requirements/18c560e.txt                                          @DataDog/apm-python

@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Jan 28, 2025

Datadog Report

Branch report: gnufede/iast-pymysql-2
Commit report: affda8a
Test service: dd-trace-py

✅ 0 Failed, 130 Passed, 1468 Skipped, 4m 45.28s Total duration (35m 49.32s time saved)

@pr-commenter
Copy link

pr-commenter bot commented Jan 28, 2025

Benchmarks

Benchmark execution time: 2025-02-03 13:57:13

Comparing candidate commit affda8a in PR branch gnufede/iast-pymysql-2 with baseline commit 4d20460 in branch 3.x-staging.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 394 metrics, 2 unstable metrics.

@gnufede gnufede force-pushed the gnufede/iast-pymysql-2 branch from 4a295bf to 8072cd8 Compare January 29, 2025 07:34
@gnufede gnufede changed the title feat(iast): add support for pymysql integration feat(iast): add support for pymysql, mysqldb integrations Jan 29, 2025
@gnufede gnufede marked this pull request as ready for review January 29, 2025 14:24
@gnufede gnufede requested review from a team as code owners January 29, 2025 14:24
@gnufede gnufede enabled auto-merge (squash) January 31, 2025 09:13
@avara1986 avara1986 added the ASM Application Security Monitoring label Jan 31, 2025
@gnufede gnufede requested a review from avara1986 February 3, 2025 08:27
@gnufede gnufede merged commit a22143d into 3.x-staging Feb 3, 2025
760 checks passed
@gnufede gnufede deleted the gnufede/iast-pymysql-2 branch February 3, 2025 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ASM Application Security Monitoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants