Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(libdatadog): bump libdatadog to v15.0.0 #12063

Merged
merged 2 commits into from
Jan 24, 2025

Conversation

BaptisteFoy
Copy link
Contributor

@BaptisteFoy BaptisteFoy commented Jan 24, 2025

This PR bumps libdatadog to the newly released v15.0.0. This will let us leverage new features such as library_config in following PRs.

Nothing should change much, so it is fine to only test this PR for non-regression.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

Copy link
Contributor

CODEOWNERS have been resolved as:

releasenotes/notes/libdatadog-v15.0.0-1004e5bb7f452d9a.yaml             @DataDog/apm-python
ddtrace/internal/datadog/profiling/cmake/FindLibdatadog.cmake           @DataDog/profiling-python
ddtrace/internal/datadog/profiling/dd_wrapper/src/crashtracker.cpp      @DataDog/profiling-python
ddtrace/internal/datadog/profiling/dd_wrapper/src/receiver_interface.cpp  @DataDog/profiling-python
setup.py                                                                @DataDog/python-guild
src/core/Cargo.lock                                                     @DataDog/apm-core-python
src/core/Cargo.toml                                                     @DataDog/apm-core-python

@datadog-dd-trace-py-rkomorn
Copy link

Datadog Report

Branch report: baptiste.foy/FA/bump-libdatadog
Commit report: 3d402e9
Test service: dd-trace-py

✅ 0 Failed, 130 Passed, 1468 Skipped, 4m 36.1s Total duration (35m 39.13s time saved)

@pr-commenter
Copy link

pr-commenter bot commented Jan 24, 2025

Benchmarks

Benchmark execution time: 2025-01-24 08:40:35

Comparing candidate commit 3d402e9 in PR branch baptiste.foy/FA/bump-libdatadog with baseline commit 7af63e4 in branch main.

Found 3 performance improvements and 0 performance regressions! Performance is the same for 391 metrics, 2 unstable metrics.

scenario:iast_aspects-ospathbasename_aspect

  • 🟩 execution_time [-350.916ns; -297.752ns] or [-9.711%; -8.240%]

scenario:iast_aspects-ospathdirname_aspect

  • 🟩 execution_time [-584.243ns; -522.028ns] or [-13.789%; -12.320%]

scenario:iast_aspects-ospathsplit_aspect

  • 🟩 execution_time [-367.120ns; -308.093ns] or [-8.783%; -7.371%]

@brettlangdon brettlangdon enabled auto-merge (squash) January 24, 2025 14:03
@brettlangdon brettlangdon merged commit cf83444 into main Jan 24, 2025
744 of 746 checks passed
@brettlangdon brettlangdon deleted the baptiste.foy/FA/bump-libdatadog branch January 24, 2025 14:09
mabdinur pushed a commit that referenced this pull request Jan 24, 2025
This PR depends on #12063.

Rename src/core to src/native. This is laying ground as a [following
PR](#11839) will need to
import native code in `ddtrace.__init__.py`. Without this change this
would create a dependency loop between `ddtrace` & `ddtrace.core`
through `event_hub.py`.

This PR only renames files, so a non-regression test is the only thing
needed.

## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met 
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants