-
Notifications
You must be signed in to change notification settings - Fork 424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(llmobs): [MLOB-1944] generalize helper for extracting token metrics #12026
Open
ncybul
wants to merge
8
commits into
main
Choose a base branch
from
nicole-cybul/generalize-metric-helpers
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+32
−50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
BenchmarksBenchmark execution time: 2025-02-04 19:25:40 Comparing candidate commit bff1be3 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 394 metrics, 2 unstable metrics. |
ncybul
added
the
changelog/no-changelog
A changelog entry is not required for this PR.
label
Jan 24, 2025
Kyle-Verhoog
approved these changes
Feb 3, 2025
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR generalizes the helper method used to extract token metrics from an APM span to be attached to an LLMObs span. Before, Anthropic, Bedrock, and Open AI had specific methods on each of their integration classes to accomplish this. Now, there is one
get_llmobs_metrics_tags
utils function adapted from the google-specificget_llmobs_metrics_tags_google
function that gets reused across these integrations as well as Vertex AI and Gemini. The Langchain integration was excluded from this change since its logic for extracting token metrics varies significantly compared to the other integrations.Testing
Anthropic
Running the code above produced this APM span and this LLM span with the following metrics:
Bedrock
Running the code above produced this APM span and this LLM span with the following metrics:
Gemini
Running the code above produced this APM span and this LLM span with the following metrics:
Open AI
Running the code above produced this APM span and this LLM span with the following metrics:
Vertex AI
Running the code above produced this APM span and this LLM span with the following metrics:
Checklist
Reviewer Checklist