Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(pin): remove all deprecated references [3.0] #11982

Merged
merged 2 commits into from
Jan 16, 2025

Conversation

mabdinur
Copy link
Contributor

@mabdinur mabdinur commented Jan 16, 2025

Motivation

Ensure deprecation warnings are only logged when users manually use deprecated interfaces.

Description

This change ensures we do not use the deprecated ddtrace.Pin reference in docs and integrations.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@mabdinur mabdinur requested review from a team as code owners January 16, 2025 14:22
Copy link
Contributor

github-actions bot commented Jan 16, 2025

CODEOWNERS have been resolved as:

ddtrace/__init__.py                                                     @DataDog/apm-core-python
ddtrace/contrib/aredis/__init__.py                                      @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/httpx/__init__.py                                       @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/internal/mongoengine/trace.py                           @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/internal/pylibmc/client.py                              @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/internal/pymongo/client.py                              @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/internal/tornado/application.py                         @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/redis/__init__.py                                       @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/yaaredis/__init__.py                                    @DataDog/apm-core-python @DataDog/apm-idm-python
docs/api.rst                                                            @DataDog/python-guild

@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Jan 16, 2025

Datadog Report

Branch report: munir/remove-deprecated-code-from-integratios
Commit report: 36bc707
Test service: dd-trace-py

✅ 0 Failed, 130 Passed, 1468 Skipped, 4m 26.01s Total duration (35m 35.15s time saved)

@mabdinur mabdinur changed the title chore(pin): remove all deprecated references chore(pin): remove all deprecated references [3.0] Jan 16, 2025
@erikayasuda erikayasuda added the changelog/no-changelog A changelog entry is not required for this PR. label Jan 16, 2025
@mabdinur mabdinur enabled auto-merge (squash) January 16, 2025 16:34
@mabdinur mabdinur merged commit b028cc6 into main Jan 16, 2025
685 checks passed
@mabdinur mabdinur deleted the munir/remove-deprecated-code-from-integratios branch January 16, 2025 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants