Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(asm): addendum to ATO V3 #11981

Merged
merged 6 commits into from
Jan 16, 2025
Merged

Conversation

christophe-papazian
Copy link
Contributor

@christophe-papazian christophe-papazian commented Jan 16, 2025

This PR fixes missing support from unreleased PR #11932

  • add better support for usr.login tag and anonymisation of the value
  • add support for WAF permanent address force resent to the WAF. This should be the default behaviour for usr.id and usr.login WAF addresses
  • add check for usr.login anonymised on threat tests and django tests
  • update processor tests for the new usr.login WAF address
  • improve user blocking mechanism by blocking as soon as we can with BlockingException

Will also enable support for system tests on DataDog/system-tests#3828 when this PR is merged.

APPSEC-56315

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@christophe-papazian christophe-papazian added changelog/no-changelog A changelog entry is not required for this PR. ASM Application Security Monitoring labels Jan 16, 2025
Copy link
Contributor

github-actions bot commented Jan 16, 2025

CODEOWNERS have been resolved as:

ddtrace/appsec/_constants.py                                            @DataDog/asm-python
ddtrace/appsec/_processor.py                                            @DataDog/asm-python
ddtrace/appsec/_trace_utils.py                                          @DataDog/asm-python
tests/appsec/appsec/test_processor.py                                   @DataDog/asm-python
tests/appsec/contrib_appsec/utils.py                                    @DataDog/asm-python
tests/contrib/django/test_django_appsec.py                              @DataDog/asm-python

@pr-commenter
Copy link

pr-commenter bot commented Jan 16, 2025

Benchmarks

Benchmark execution time: 2025-01-16 16:44:09

Comparing candidate commit 6cab169 in PR branch christophe-papazian/fix_ato_v3 with baseline commit 4183671 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 380 metrics, 2 unstable metrics.

@christophe-papazian christophe-papazian marked this pull request as ready for review January 16, 2025 16:57
@christophe-papazian christophe-papazian requested a review from a team as a code owner January 16, 2025 16:57
@christophe-papazian christophe-papazian enabled auto-merge (squash) January 16, 2025 17:03
@christophe-papazian christophe-papazian merged commit eddd514 into main Jan 16, 2025
328 checks passed
@christophe-papazian christophe-papazian deleted the christophe-papazian/fix_ato_v3 branch January 16, 2025 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ASM Application Security Monitoring changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants