ci: fix flaky aiohttp test failure [backport 2.17] #11974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Co-authored-by: erikayasuda <153395705+erikayasuda@users.noreply.github.com> (cherry picked from commit d364f1b)
github-actions
bot
added
changelog/no-changelog
erikayasuda
approved these changes
Jan 15, 2025
|
|
erikayasuda
pushed a commit
that referenced
this pull request
Jan 16, 2025
Backport d364f1b from #11698 to 2.17. There is something about this test which leaks bad behavior over to other tests when run in specific order. Using `--randomly-seed=4013706280` will simulate the same test execution order as an example failing job to reproduce the behavior consistently. I do not really understand the root cause of this issue, but removing the extra patch/unpatch calls does resolve the issue and keeps the original test as passing. The failing behavior on the `test_distributed_tracing` test was that the passed in distributed tracing headers were not honored. I _think_ this is because the test expects an unpatched aiohttp client, but we are actually getting a patched one, so it is creating a span and injecting it's distributed headers into the request. ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) Co-authored-by: Brett Langdon <brett.langdon@datadoghq.com> (cherry picked from commit aa59f38)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport d364f1b from #11698 to 2.17.
There is something about this test which leaks bad behavior over to other tests when run in specific order.
Using
--randomly-seed=4013706280will simulate the same test execution order as an example failing job to reproduce the behavior consistently.I do not really understand the root cause of this issue, but removing the extra patch/unpatch calls does resolve the issue and keeps the original test as passing.
The failing behavior on the
test_distributed_tracingtest was that the passed in distributed tracing headers were not honored. I think this is because the test expects an unpatched aiohttp client, but we are actually getting a patched one, so it is creating a span and injecting it's distributed headers into the request.Checklist
Reviewer Checklist