Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(botocore): fix flaky botocore tests [backport 2.18] #11968

Merged
merged 1 commit into from
Jan 15, 2025
Merged

ci(botocore): fix flaky botocore tests [backport 2.18] #11968

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions tests/contrib/botocore/test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@

from ddtrace._trace._span_pointer import _SpanPointer
from ddtrace._trace._span_pointer import _SpanPointerDirection
from ddtrace._trace.utils_botocore import span_tags
from tests.utils import get_128_bit_trace_id_from_headers


Expand Down Expand Up @@ -104,6 +105,12 @@ def setUp(self):
super(BotocoreTest, self).setUp()

Pin(service=self.TEST_SERVICE, tracer=self.tracer).onto(botocore.parsers.ResponseParser)
# Setting the validated flag to False ensures the redaction paths configurations are re-validated
# FIXME: Ensure AWSPayloadTagging._REQUEST_REDACTION_PATHS_DEFAULTS is always in sync with
# config.botocore.payload_tagging_request
# FIXME: Ensure AWSPayloadTagging._RESPONSE_REDACTION_PATHS_DEFAULTS is always in sync with
# config.botocore.payload_tagging_response
span_tags._PAYLOAD_TAGGER.validated = False

def tearDown(self):
super(BotocoreTest, self).tearDown()
Expand Down
Loading