Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: do not use datadog-ci binary [backport 2.18] #11954

Closed
wants to merge 1 commit into from

Conversation

github-actions[bot]
Copy link
Contributor

Backport f483beb from #11789 to 2.18.

The datadog-ci binary is in beta and has known segfaults, this is blocking our CI from completing successfully, even when gates do not fail.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@github-actions github-actions bot added the changelog/no-changelog A changelog entry is not required for this PR. label Jan 15, 2025
@github-actions github-actions bot requested a review from a team as a code owner January 15, 2025 15:58
@github-actions github-actions bot requested a review from erikayasuda January 15, 2025 15:58
@erikayasuda erikayasuda enabled auto-merge (squash) January 15, 2025 15:59
auto-merge was automatically disabled January 15, 2025 15:59

Pull request was closed

@erikayasuda erikayasuda reopened this Jan 15, 2025
@erikayasuda erikayasuda enabled auto-merge (squash) January 15, 2025 15:59
Copy link
Contributor Author

CODEOWNERS have been resolved as:

.gitlab-ci.yml                                                          @DataDog/apm-core-python

@pr-commenter
Copy link

pr-commenter bot commented Jan 15, 2025

Benchmarks

Benchmark execution time: 2025-01-15 16:39:54

Comparing candidate commit 8222d20 in PR branch backport-11789-to-2.18 with baseline commit e632119 in branch 2.18.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 394 metrics, 2 unstable metrics.

@erikayasuda
Copy link
Contributor

Got manually merged into 2.18 already. Closing.

auto-merge was automatically disabled January 15, 2025 18:14

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants