-
Notifications
You must be signed in to change notification settings - Fork 420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(lib-injection): fix incorrect telemetry data payload format #11950
Conversation
|
Datadog ReportBranch report: ✅ 0 Failed, 130 Passed, 1468 Skipped, 4m 29.37s Total duration (35m 28.19s time saved) |
BenchmarksBenchmark execution time: 2025-01-16 20:15:47 Comparing candidate commit 1c08bfa in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 208 metrics, 2 unstable metrics. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one release note nit
releasenotes/notes/fix-ssi-telemetry-events-a0a01ad0b6ef63b5.yaml
Outdated
Show resolved
Hide resolved
Co-authored-by: erikayasuda <153395705+erikayasuda@users.noreply.github.com>
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.18 2.18
# Navigate to the new working tree
cd .worktrees/backport-2.18
# Create a new branch
git switch --create backport-11950-to-2.18
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 7f2e40ce5bcf7f3c084139bb02c06fd4299db75e
# Push it to GitHub
git push --set-upstream origin backport-11950-to-2.18
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.18 Then, create a pull request where the |
Co-authored-by: erikayasuda <153395705+erikayasuda@users.noreply.github.com> (cherry picked from commit 7f2e40c)
We aggregate all telemetry data and then send only once, however we were sometimes aggregating payloads and other times aggregating individual metric events.
This PR fixes the inconsistency by only aggregating the metric events, and sending one single payload at the end.
Checklist
Reviewer Checklist