Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): new testrunner for check_new_flaky_tests [2.17] #11947

Merged
merged 6 commits into from
Jan 15, 2025

Conversation

juanjux
Copy link
Collaborator

@juanjux juanjux commented Jan 15, 2025

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

Signed-off-by: Juanjo Alvarez <juanjo.alvarezmartinez@datadoghq.com>
@juanjux juanjux self-assigned this Jan 15, 2025
@juanjux juanjux requested a review from a team as a code owner January 15, 2025 11:08
@juanjux juanjux requested a review from emmettbutler January 15, 2025 11:08
Copy link
Contributor

github-actions bot commented Jan 15, 2025

CODEOWNERS have been resolved as:

.gitlab-ci.yml                                                          @DataDog/apm-core-python
.gitlab/testrunner.yml                                                  @DataDog/python-guild @DataDog/apm-core-python
.gitlab/tests.yml                                                       @DataDog/python-guild @DataDog/apm-core-python

@juanjux juanjux added changelog/no-changelog A changelog entry is not required for this PR. ASM Application Security Monitoring labels Jan 15, 2025
@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Jan 15, 2025

Datadog Report

Branch report: juanjux/new-testrunner-for-flaky-tests-217
Commit report: edb7a1c
Test service: dd-trace-py

✅ 0 Failed, 592 Passed, 694 Skipped, 18m 35.29s Total duration (17m 37.82s time saved)

Signed-off-by: Juanjo Alvarez <juanjo.alvarezmartinez@datadoghq.com>
@juanjux juanjux requested a review from a team as a code owner January 15, 2025 11:37
Signed-off-by: Juanjo Alvarez <juanjo.alvarezmartinez@datadoghq.com>
@pr-commenter
Copy link

pr-commenter bot commented Jan 15, 2025

Benchmarks

Benchmark execution time: 2025-01-15 20:41:46

Comparing candidate commit edb7a1c in PR branch juanjux/new-testrunner-for-flaky-tests-217 with baseline commit 3961c8d in branch 2.17.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 388 metrics, 2 unstable metrics.

@juanjux juanjux enabled auto-merge (squash) January 15, 2025 17:42
@erikayasuda
Copy link
Contributor

Blocked on #11955

@juanjux juanjux merged commit a419d97 into 2.17 Jan 15, 2025
638 checks passed
@juanjux juanjux deleted the juanjux/new-testrunner-for-flaky-tests-217 branch January 15, 2025 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ASM Application Security Monitoring changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants