Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: optimize ci runtime [backport 2.19] #11937

Merged
merged 2 commits into from
Jan 16, 2025
Merged

Conversation

erikayasuda
Copy link
Contributor

@erikayasuda erikayasuda commented Jan 14, 2025

Manual backport for #11798 into 2.19

  • Remove redundant build_base_venvs
    • not needed by any downstream jobs, we have to re-do this in the tests-gen pipeline anyways
  • Move conftest hatch job from precheck to hatch stage
    • hatch jobs that have to install dev take a long time to run 6+ mins
  • Remove redundant .testrunner definition, and need for injecting services.yml into tests.yml template

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@erikayasuda erikayasuda added the changelog/no-changelog A changelog entry is not required for this PR. label Jan 14, 2025
@erikayasuda erikayasuda reopened this Jan 14, 2025
Copy link
Contributor

CODEOWNERS have been resolved as:

.gitlab/package.yml                                                     @DataDog/python-guild @DataDog/apm-core-python
.gitlab/tests.yml                                                       @DataDog/python-guild @DataDog/apm-core-python
hatch.toml                                                              @DataDog/python-guild
scripts/gen_gitlab_config.py                                            @DataDog/apm-core-python
tests/suitespec.yml                                                     @DataDog/python-guild @DataDog/apm-core-python

@pr-commenter
Copy link

pr-commenter bot commented Jan 14, 2025

Benchmarks

Benchmark execution time: 2025-01-16 01:11:34

Comparing candidate commit e9680ef in PR branch backport-11798-to-2.19 with baseline commit e16d68c in branch 2.19.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 394 metrics, 2 unstable metrics.

@erikayasuda erikayasuda marked this pull request as ready for review January 16, 2025 00:28
@erikayasuda erikayasuda requested review from a team as code owners January 16, 2025 00:28
@erikayasuda erikayasuda merged commit c9ea15c into 2.19 Jan 16, 2025
659 checks passed
@erikayasuda erikayasuda deleted the backport-11798-to-2.19 branch January 16, 2025 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants