Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(asm): update the ATO support with the new specifications #11932

Merged
merged 16 commits into from
Jan 16, 2025

Conversation

christophe-papazian
Copy link
Contributor

@christophe-papazian christophe-papazian commented Jan 14, 2025

  • Add support for ATO V3 RFC by adding missing tags
  • Update unit threat tests accordingly

APPSEC-56315

Once merged, this will also be tested with ATO V3 system tests.
DataDog/system-tests#3828

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

Copy link
Contributor

github-actions bot commented Jan 14, 2025

CODEOWNERS have been resolved as:

releasenotes/notes/ATO_V3-e7f73ecf00d1474b.yaml                         @DataDog/apm-python
ddtrace/appsec/_constants.py                                            @DataDog/asm-python
ddtrace/appsec/_trace_utils.py                                          @DataDog/asm-python
tests/appsec/contrib_appsec/fastapi_app/app.py                          @DataDog/asm-python
tests/appsec/contrib_appsec/flask_app/app.py                            @DataDog/asm-python
tests/appsec/contrib_appsec/utils.py                                    @DataDog/asm-python

@pr-commenter
Copy link

pr-commenter bot commented Jan 14, 2025

Benchmarks

Benchmark execution time: 2025-01-15 14:14:32

Comparing candidate commit 7d20fb6 in PR branch christophe-papazian/support_ATO_V3 with baseline commit fce6d75 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 206 metrics, 2 unstable metrics.

@christophe-papazian christophe-papazian added the changelog/no-changelog A changelog entry is not required for this PR. label Jan 14, 2025
ddtrace/appsec/_trace_utils.py Outdated Show resolved Hide resolved
ddtrace/appsec/_trace_utils.py Outdated Show resolved Hide resolved
@christophe-papazian christophe-papazian changed the title chore(asm): update the ATO support with the new specifications feat(asm): update the ATO support with the new specifications Jan 15, 2025
@christophe-papazian christophe-papazian marked this pull request as ready for review January 15, 2025 14:59
@christophe-papazian christophe-papazian requested review from a team as code owners January 15, 2025 14:59
@christophe-papazian christophe-papazian merged commit d696c67 into main Jan 16, 2025
326 checks passed
@christophe-papazian christophe-papazian deleted the christophe-papazian/support_ATO_V3 branch January 16, 2025 08:49
christophe-papazian added a commit that referenced this pull request Jan 16, 2025
This PR fixes missing support from unreleased PR
#11932

- add better support for usr.login tag and anonymisation of the value
- add support for WAF permanent address force resent to the WAF. This
should be the default behaviour for usr.id and usr.login WAF addresses
- add check for usr.login anonymised on threat tests and django tests
- update processor tests for the new usr.login WAF address
- improve user blocking mechanism by blocking as soon as we can with
BlockingException

Will also enable support for system tests on
DataDog/system-tests#3828 when this PR is
merged.

APPSEC-56315

## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met 
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants