-
Notifications
You must be signed in to change notification settings - Fork 420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(asm): update the ATO support with the new specifications #11932
Merged
christophe-papazian
merged 16 commits into
main
from
christophe-papazian/support_ATO_V3
Jan 16, 2025
Merged
feat(asm): update the ATO support with the new specifications #11932
christophe-papazian
merged 16 commits into
main
from
christophe-papazian/support_ATO_V3
Jan 16, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
BenchmarksBenchmark execution time: 2025-01-15 14:14:32 Comparing candidate commit 7d20fb6 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 206 metrics, 2 unstable metrics. |
christophe-papazian
added
the
changelog/no-changelog
A changelog entry is not required for this PR.
label
Jan 14, 2025
christophe-papazian
changed the title
chore(asm): update the ATO support with the new specifications
feat(asm): update the ATO support with the new specifications
Jan 15, 2025
7 tasks
gnufede
approved these changes
Jan 16, 2025
2 tasks
christophe-papazian
added a commit
that referenced
this pull request
Jan 16, 2025
This PR fixes missing support from unreleased PR #11932 - add better support for usr.login tag and anonymisation of the value - add support for WAF permanent address force resent to the WAF. This should be the default behaviour for usr.id and usr.login WAF addresses - add check for usr.login anonymised on threat tests and django tests - update processor tests for the new usr.login WAF address - improve user blocking mechanism by blocking as soon as we can with BlockingException Will also enable support for system tests on DataDog/system-tests#3828 when this PR is merged. APPSEC-56315 ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
APPSEC-56315
Once merged, this will also be tested with ATO V3 system tests.
DataDog/system-tests#3828
Checklist
Reviewer Checklist