Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(appsec): migrate test integrations to gitlab #11931

Merged
merged 17 commits into from
Jan 16, 2025

Conversation

avara1986
Copy link
Member

@avara1986 avara1986 commented Jan 14, 2025

Partial migration of the tests in appsec/integrations/

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@avara1986 avara1986 added changelog/no-changelog A changelog entry is not required for this PR. ASM Application Security Monitoring labels Jan 14, 2025
Copy link
Contributor

github-actions bot commented Jan 14, 2025

CODEOWNERS have been resolved as:

.riot/requirements/5e31227.txt                                          @DataDog/apm-python
.riot/requirements/628e8fe.txt                                          @DataDog/apm-python
.riot/requirements/8dd53b1.txt                                          @DataDog/apm-python
.riot/requirements/968fdc9.txt                                          @DataDog/apm-python
tests/appsec/integrations/django_tests/__init__.py                      @DataDog/asm-python
tests/appsec/integrations/flask_tests/__init__.py                       @DataDog/asm-python
.circleci/config.templ.yml                                              @DataDog/python-guild @DataDog/apm-core-python
hatch.toml                                                              @DataDog/python-guild
riotfile.py                                                             @DataDog/apm-python
tests/appsec/app.py                                                     @DataDog/asm-python
tests/appsec/suitespec.yml                                              @DataDog/asm-python
tests/appsec/integrations/flask_tests/module_with_import_errors.py      @DataDog/asm-python
tests/appsec/integrations/flask_tests/test_flask_remoteconfig.py        @DataDog/asm-python
tests/appsec/integrations/flask_tests/test_gunicorn_handlers.py         @DataDog/asm-python
tests/appsec/integrations/flask_tests/test_iast_flask_entrypoint_iast_patches.py  @DataDog/asm-python
tests/appsec/integrations/flask_tests/test_iast_flask_patching.py       @DataDog/asm-python
tests/appsec/integrations/flask_tests/test_iast_flask_telemetry.py      @DataDog/asm-python
tests/appsec/integrations/flask_tests/test_iast_langchain.py            @DataDog/asm-python
tests/appsec/integrations/flask_tests/test_iast_psycopg2.py             @DataDog/asm-python
tests/appsec/integrations/flask_tests/utils.py                          @DataDog/asm-python

@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Jan 14, 2025

Datadog Report

Branch report: avara1986/APPSEC-56157-migrate_iast_django
Commit report: 0a40b2a
Test service: dd-trace-py

✅ 0 Failed, 130 Passed, 1468 Skipped, 4m 30.26s Total duration (35m 27.96s time saved)

@pr-commenter
Copy link

pr-commenter bot commented Jan 14, 2025

Benchmarks

Benchmark execution time: 2025-01-16 08:59:47

Comparing candidate commit 0a40b2a in PR branch avara1986/APPSEC-56157-migrate_iast_django with baseline commit 87a74ae in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 380 metrics, 2 unstable metrics.

@avara1986 avara1986 changed the title chore: split flask and pygoat tests chore(appsec): migrate test integrations to gitlab Jan 14, 2025
@avara1986 avara1986 marked this pull request as ready for review January 15, 2025 08:12
@avara1986 avara1986 requested review from a team as code owners January 15, 2025 08:12
@avara1986 avara1986 changed the title chore(appsec): migrate test integrations to gitlab chore(appsec): migrate test integrations to gitlab Jan 15, 2025
@avara1986 avara1986 enabled auto-merge (squash) January 16, 2025 09:15
@avara1986 avara1986 merged commit c46c302 into main Jan 16, 2025
697 checks passed
@avara1986 avara1986 deleted the avara1986/APPSEC-56157-migrate_iast_django branch January 16, 2025 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ASM Application Security Monitoring changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants