Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(profiling): remove _self_acquired_at after use #11898

Merged
merged 2 commits into from
Jan 10, 2025
Merged

fix(profiling): remove _self_acquired_at after use #11898

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
81632a6
remove self_acquired_at
taegyunkim Jan 10, 2025
93d6c51
add relnote
taegyunkim Jan 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ddtrace/profiling/collector/_lock.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,6 +185,7 @@ def _release(self, inner_func, *args, **kwargs):
# _self_acquired_at is only set when the acquire was captured
# if it's not set, we're not capturing the release
start = self._self_acquired_at
del self._self_acquired_at

try:
return inner_func(*args, **kwargs)
Expand Down
5 changes: 5 additions & 0 deletions releasenotes/notes/profiling-lock-acquired-at-remove-c8b5b96130a46ca8.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
fixes:
- |
profiling: resolves an issue where lock release would have been captured
with a wrong acquire timestamp
Loading