Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(profiling): remove _self_acquired_at after use #11898

Merged
merged 2 commits into from
Jan 10, 2025

Conversation

taegyunkim
Copy link
Contributor

@taegyunkim taegyunkim commented Jan 10, 2025

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@taegyunkim taegyunkim requested a review from a team as a code owner January 10, 2025 16:07
Copy link
Contributor

github-actions bot commented Jan 10, 2025

CODEOWNERS have been resolved as:

releasenotes/notes/profiling-lock-acquired-at-remove-c8b5b96130a46ca8.yaml  @DataDog/apm-python
ddtrace/profiling/collector/_lock.py                                    @DataDog/profiling-python

@taegyunkim taegyunkim requested a review from a team as a code owner January 10, 2025 16:09
@pr-commenter
Copy link

pr-commenter bot commented Jan 10, 2025

Benchmarks

Benchmark execution time: 2025-01-10 16:51:17

Comparing candidate commit 93d6c51 in PR branch taegyunkim/prof-11054-lock-test with baseline commit 5e68823 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 394 metrics, 2 unstable metrics.

Copy link
Contributor

@sanchda sanchda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahhh, interesting. 👍

@taegyunkim taegyunkim merged commit a58f139 into main Jan 10, 2025
193 of 194 checks passed
@taegyunkim taegyunkim deleted the taegyunkim/prof-11054-lock-test branch January 10, 2025 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants