Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(er): include nonlocals in snapshots #11894

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Conversation

P403n1x87
Copy link
Contributor

@P403n1x87 P403n1x87 commented Jan 10, 2025

We include nonlocal variables in snapshots to provide for better visibility into exception occurrences.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@P403n1x87 P403n1x87 added the Dynamic Instrumentation Dynamic Instrumentation/Live Debugger label Jan 10, 2025
@P403n1x87 P403n1x87 requested review from a team as code owners January 10, 2025 13:44
Copy link
Contributor

github-actions bot commented Jan 10, 2025

CODEOWNERS have been resolved as:

releasenotes/notes/fix-er-include-nonlocals-bbeecfbbbde35496.yaml       @DataDog/apm-python
ddtrace/debugging/_safety.py                                            @DataDog/debugger-python
tests/debugging/exception/test_replay.py                                @DataDog/debugger-python
tests/debugging/test_safety.py                                          @DataDog/debugger-python

@P403n1x87 P403n1x87 force-pushed the fix/er-include-nonlocals branch from 0cb0431 to 01cff99 Compare January 10, 2025 13:54
@datadog-dd-trace-py-rkomorn
Copy link

Datadog Report

Branch report: fix/er-include-nonlocals
Commit report: 0cb0431
Test service: dd-trace-py

✅ 0 Failed, 55 Passed, 1434 Skipped, 2m 2.41s Total duration (31m 12.06s time saved)

We include nonlocal variables in snapshots to provide for better
visibility into exception occurrences.
@P403n1x87 P403n1x87 force-pushed the fix/er-include-nonlocals branch from 01cff99 to 2b42c91 Compare January 10, 2025 14:24
@P403n1x87 P403n1x87 enabled auto-merge (squash) January 10, 2025 14:24
@pr-commenter
Copy link

pr-commenter bot commented Jan 10, 2025

Benchmarks

Benchmark execution time: 2025-01-10 15:05:24

Comparing candidate commit 2b42c91 in PR branch fix/er-include-nonlocals with baseline commit afe439e in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 394 metrics, 2 unstable metrics.

@P403n1x87 P403n1x87 merged commit d7927e6 into main Jan 10, 2025
152 of 153 checks passed
@P403n1x87 P403n1x87 deleted the fix/er-include-nonlocals branch January 10, 2025 18:45
Copy link
Contributor

The backport to 2.16 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.16 2.16
# Navigate to the new working tree
cd .worktrees/backport-2.16
# Create a new branch
git switch --create backport-11894-to-2.16
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d7927e6296679a3d7def5b31347262b7cce8b7dd
# Push it to GitHub
git push --set-upstream origin backport-11894-to-2.16
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.16

Then, create a pull request where the base branch is 2.16 and the compare/head branch is backport-11894-to-2.16.

Copy link
Contributor

The backport to 2.17 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.17 2.17
# Navigate to the new working tree
cd .worktrees/backport-2.17
# Create a new branch
git switch --create backport-11894-to-2.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d7927e6296679a3d7def5b31347262b7cce8b7dd
# Push it to GitHub
git push --set-upstream origin backport-11894-to-2.17
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.17

Then, create a pull request where the base branch is 2.17 and the compare/head branch is backport-11894-to-2.17.

github-actions bot pushed a commit that referenced this pull request Jan 10, 2025
We include nonlocal variables in snapshots to provide for better
visibility into exception occurrences.

## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [ ] Reviewer has checked that all the criteria below are met
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

(cherry picked from commit d7927e6)
github-actions bot pushed a commit that referenced this pull request Jan 10, 2025
We include nonlocal variables in snapshots to provide for better
visibility into exception occurrences.

## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [ ] Reviewer has checked that all the criteria below are met
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

(cherry picked from commit d7927e6)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants