Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: clean up snowflake instructions #11891

Merged
merged 2 commits into from
Jan 15, 2025
Merged

chore: clean up snowflake instructions #11891

merged 2 commits into from
Jan 15, 2025

Conversation

wantsui
Copy link
Collaborator

@wantsui wantsui commented Jan 9, 2025

The current doc makes it seem like you need to call both patch and patch call at the same time:

from ddtrace import patch, patch_all
patch(snowflake=True)
patch_all(snowflake=True)

This PR splits it out.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@wantsui wantsui added the changelog/no-changelog A changelog entry is not required for this PR. label Jan 9, 2025
Copy link
Contributor

github-actions bot commented Jan 9, 2025

CODEOWNERS have been resolved as:

ddtrace/contrib/snowflake/__init__.py                                   @DataDog/apm-core-python @DataDog/apm-idm-python

@datadog-dd-trace-py-rkomorn
Copy link

Datadog Report

Branch report: wantsui/snowflake
Commit report: 392b1c6
Test service: dd-trace-py

✅ 0 Failed, 87 Passed, 1468 Skipped, 4m 1.16s Total duration (35m 41.19s time saved)

@pr-commenter
Copy link

pr-commenter bot commented Jan 10, 2025

Benchmarks

Benchmark execution time: 2025-01-10 21:58:36

Comparing candidate commit c878159 in PR branch wantsui/snowflake with baseline commit a58f139 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 394 metrics, 2 unstable metrics.

@wantsui wantsui marked this pull request as ready for review January 10, 2025 00:22
@wantsui wantsui requested review from a team as code owners January 10, 2025 00:22
@wantsui wantsui merged commit cdfc0a6 into main Jan 15, 2025
154 of 155 checks passed
@wantsui wantsui deleted the wantsui/snowflake branch January 15, 2025 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants