Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix flaky test_custom_traceback_size_with_error on Python 3.13 #11858

Merged
merged 2 commits into from
Jan 7, 2025

Conversation

brettlangdon
Copy link
Member

@brettlangdon brettlangdon commented Jan 6, 2025

Under newer Python versions we sometimes get tracebacks that contain pointers, we need to account for these in the assertion.

Traceback (most recent call last):
  File "dd-trace-py/tests/tracer/test_span.py", line 279, in test_custom_traceback_size_with_error
    wrapper()
    ~~~~~~~^^
  File "dd-trace-py/tests/tracer/test_span.py", line 276, in wrapper
    divide_by_zero()
    ~~~~~~~~~~~~~~^^
ZeroDivisionError: division by zero

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@brettlangdon brettlangdon added the changelog/no-changelog A changelog entry is not required for this PR. label Jan 6, 2025
@brettlangdon brettlangdon requested a review from a team as a code owner January 6, 2025 18:15
@brettlangdon
Copy link
Member Author

brettlangdon commented Jan 6, 2025

I have no idea why this is flaky instead of always failing.

Or why test_custom_traceback_size isn't also flaky.

Copy link
Contributor

github-actions bot commented Jan 6, 2025

CODEOWNERS have been resolved as:

tests/tracer/test_span.py                                               @DataDog/apm-sdk-api-python

@brettlangdon brettlangdon changed the title ci: Fix flaky SpanTestCase::test_custom_traceback_size_with_error on Python 3.13 ci: fix flaky test_custom_traceback_size_with_error on Python 3.13 Jan 6, 2025
@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Jan 6, 2025

Datadog Report

Branch report: brettlangdon/flaky.tracer.test
Commit report: f7ad5eb
Test service: dd-trace-py

✅ 0 Failed, 87 Passed, 1468 Skipped, 3m 44.62s Total duration (35m 20.09s time saved)

@brettlangdon brettlangdon enabled auto-merge (squash) January 6, 2025 18:32
@pr-commenter
Copy link

pr-commenter bot commented Jan 6, 2025

Benchmarks

Benchmark execution time: 2025-01-06 20:47:32

Comparing candidate commit f7ad5eb in PR branch brettlangdon/flaky.tracer.test with baseline commit 81208cd in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 394 metrics, 2 unstable metrics.

@brettlangdon brettlangdon merged commit 6620f9b into main Jan 7, 2025
242 checks passed
@brettlangdon brettlangdon deleted the brettlangdon/flaky.tracer.test branch January 7, 2025 18:14
github-actions bot pushed a commit that referenced this pull request Jan 13, 2025
erikayasuda pushed a commit that referenced this pull request Jan 13, 2025
…ackport 2.19] (#11922)

Backport 6620f9b from #11858 to 2.19.

Under newer Python versions we sometimes get tracebacks that contain
pointers, we need to account for these in the assertion.

```
Traceback (most recent call last):
  File "dd-trace-py/tests/tracer/test_span.py", line 279, in test_custom_traceback_size_with_error
    wrapper()
    ~~~~~~~^^
  File "dd-trace-py/tests/tracer/test_span.py", line 276, in wrapper
    divide_by_zero()
    ~~~~~~~~~~~~~~^^
ZeroDivisionError: division by zero
```


## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met 
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

Co-authored-by: Brett Langdon <brett.langdon@datadoghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.19 changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants