ci: revert CI fix #11807
Merged
ci: revert CI fix #11807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit fb82c64.
emmettbutler
requested review from
erikayasuda,
P403n1x87 and
brettlangdon
and removed request for
erikayasuda
brettlangdon
approved these changes
Dec 19, 2024
|
|
emmettbutler
added
the
changelog/no-changelog
emmettbutler
added
changelog/no-changelog
Datadog ReportBranch report: ✅ 0 Failed, 257 Passed, 1211 Skipped, 4m 34.04s Total duration (29m 7.99s time saved) |
BenchmarksBenchmark execution time: 2024-12-19 23:45:31 Comparing candidate commit ffd885a in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 332 metrics, 2 unstable metrics. |
2 tasks
avara1986
added a commit
that referenced
this pull request
Jan 13, 2025
Tests packages are failing in main on CircleCi due to timeout. We’re not sure the root cause because the CI has been broken for over 7 days, until #11807 reverted the changes. Making it nearly impossible to pinpoint where the issue started in CircleCI. So, W've decided it's time to migrate this to GitLab CAVEAT: test_packages will only run on the main branch. Therefore, these tests haven't been executed in this PR, but the [previous commit](0cec964) included a configuration to run them here to validate functionality https://gitlab.ddbuild.io/DataDog/apm-reliability/dd-trace-py/-/jobs/748795172 ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit fb82c64.
This merge commit
seems to have broken the suite-selection mechanism in CircleCI (example)
Checklist
Reviewer Checklist