-
Notifications
You must be signed in to change notification settings - Fork 424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(telemetry): improves typing for telemetry metric namespaces #11564
chore(telemetry): improves typing for telemetry metric namespaces #11564
Conversation
|
BenchmarksBenchmark execution time: 2025-01-14 15:14:01 Comparing candidate commit 958b885 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 394 metrics, 2 unstable metrics. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from the CI Visibility side.
Datadog ReportBranch report: ✅ 0 Failed, 130 Passed, 1468 Skipped, 4m 40.08s Total duration (27m 47.59s time saved) |
@vitor-de-araujo Could you take a look at this PR if you have a chance? Romain's approval doesn't count for CI Vis anymore 😢 |
Follow up to: #11565
Prevents telemetry metrics from being queued with an invalid namespace
Checklist
Reviewer Checklist