[PROF-10953] feat: Add GoPCLnTab support as SymbolSource #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsavoire
changed the title
nsavoire
changed the title
nsavoire
force-pushed
the
nsavoire/add_gopclntab_symbol_source
branch
5 times, most recently
from
ab8e393 to
9c7bdca
Compare
felixge
approved these changes
Nov 27, 2024
nsavoire
force-pushed
the
nsavoire/add_gopclntab_symbol_source
branch
3 times, most recently
from
fe0b3b6 to
40af65c
Compare
nsavoire
commented
Nov 29, 2024
nsavoire
force-pushed
the
nsavoire/add_gopclntab_symbol_source
branch
from
bd936a3 to
ff1a0ce
Compare
![datadog-datadog-prod-us1[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
nsavoire
force-pushed
the
nsavoire/add_gopclntab_symbol_source
branch
2 times, most recently
from
817a0a3 to
a321f29
Compare
nsavoire
force-pushed
the
nsavoire/add_gopclntab_symbol_source
branch
from
97a6d80 to
3042a47
Compare
r1viollet
approved these changes
Jan 8, 2025
nsavoire
force-pushed
the
nsavoire/add_gopclntab_symbol_source
branch
3 times, most recently
from
bfa87ba to
62d3925
Compare
This change adds support for uploading the .gopclntab section to SymbolUploader. This is disabled by default, and can be enabled by using the `--upload-gopclntab` CLI flag.
nsavoire
force-pushed
the
nsavoire/add_gopclntab_symbol_source
branch
from
62d3925 to
600e782
Compare
Gandem
reviewed
Jan 28, 2025
pclntab/pclntab.go
Outdated
| if !goFuncEndFound { | ||
| // Iterate over the functions to find the maximum offset of the inline tree. | ||
| maxInlineTreeOffset := goPCLnTabInfo.findMaxInlineTreeOffset() | ||
| // If the inline tree offset is found, truncate the goFunc data. |
There was a problem hiding this comment.
Can this fail? If we can't find the offset will we fail to truncate?
There was a problem hiding this comment.
If it fails, then goFunc is now discarded
Gandem
reviewed
Jan 28, 2025
Gandem
reviewed
Jan 28, 2025
Gandem
reviewed
Jan 28, 2025
Gandem
reviewed
Jan 28, 2025
Gandem
reviewed
Jan 28, 2025
nsavoire
force-pushed
the
nsavoire/add_gopclntab_symbol_source
branch
from
c8ea0f3 to
a83721c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This change adds support for uploading the
.gopclntabsection to SymbolUploader.This is disabled by default, and can be enabled by using the
--upload-gopclntabCLI flag.Motivation
Go executables always have a gopclntab section that contain symbol information and can be used to symbolicate addresses even when executable is stripped.
The new 'gopclntab' symbol source has a higher precedence than 'symbol_table' but lower than 'debug_info'. The rationale is that gopclntab covers only Go code, if the executable embeds some C/C++/Rust, then those parts will be described by dwarf. We want to prioritize symbol sources that potentially cover all executable (for example if executable is stripped, profiler will upload symbol information with 'gopclntab' as source, and later on an unstripped version could be uploaded with datadog-ci with 'debug_info' as source and will replace the existing symbols).