Svls 6036 respect timeouts #537
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
alexgallotta
commented
Feb 3, 2025
alexgallotta
commented
- use configured flush timeout for traces and stats
- respect the flush timeout, removing tracer retries
- add logs of timing for shipping data
astuyve
reviewed
Feb 4, 2025
bottlecap/Cargo.toml
Outdated
| @@ -15,7 +15,7 @@ datadog-trace-utils = { git = "https://github.com/DataDog/libdatadog", rev = "eb | |||
| datadog-trace-mini-agent = { git = "https://github.com/DataDog/libdatadog", rev = "eb82b62002a897a8bb9fe1e1cfa49170a9ea6b21" } | |||
| datadog-trace-normalization = { git = "https://github.com/DataDog/libdatadog", rev = "eb82b62002a897a8bb9fe1e1cfa49170a9ea6b21" } | |||
| datadog-trace-obfuscation = { git = "https://github.com/DataDog/libdatadog", rev = "eb82b62002a897a8bb9fe1e1cfa49170a9ea6b21" } | |||
| dogstatsd = { git = "https://github.com/DataDog/libdatadog", rev = "eb82b62002a897a8bb9fe1e1cfa49170a9ea6b21" } | |||
| dogstatsd = { git = "https://github.com/DataDog/libdatadog", rev = "5bba5f1415fa07a5a2fc04ec6a3a533909dda1e5" } | |||
There was a problem hiding this comment.
This is fine but let's bump it to the commit once you merge to main in libdatadog, because my FD leak fix will overwrite this as yours isn't in main yet
alexgallotta
force-pushed
the
SVLS-6036-respect-timeouts
branch
from
2551631 to
b3e15e4
Compare
alexgallotta
force-pushed
the
SVLS-6036-respect-timeouts
branch
from
b3e15e4 to
19bf675
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.