Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Clear env vars before running #209

Merged
merged 1 commit into from
Apr 16, 2024
Merged

feat: Clear env vars before running #209

merged 1 commit into from
Apr 16, 2024

Conversation

astuyve
Copy link
Contributor

@astuyve astuyve commented Apr 16, 2024

DATADOG_ROOT is set on my machine and conflicts with this test, throwing an unexpected field error with name root.

This fixes it.

@astuyve astuyve requested a review from a team as a code owner April 16, 2024 19:36
duncanista
duncanista approved these changes Apr 16, 2024
View reviewed changes
Copy link
Contributor

@duncanista duncanista left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM – we should add setup and teardown eventually.

@astuyve
Copy link
Contributor Author

astuyve commented Apr 16, 2024

Not sure how that would work with figment jails but we can certainly try.

@astuyve astuyve merged commit aa14037 into main Apr 16, 2024
6 checks passed
@astuyve astuyve deleted the aj/fix-units branch April 16, 2024 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duncanista duncanista duncanista approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@astuyve @duncanista