-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AGENT-11268] Add a performance tuning note about increasing records per poll #44
Conversation
…per poll Signed-off-by: Jesse Szwedko <jesse.szwedko@datadoghq.com>
Co-authored-by: Luke Steensen <luke.steensen@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added an oxford comma.
* Update the number of records fetched per poll by setting | ||
`consumer.override.max.poll.records` in the plugin configuration. This plugin | ||
sends batches of records synchronously with each poll so a low number of records | ||
per poll will reduce throughput. Consider setting this to 500 or 1000. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Non-blocking, why are sentences broken up like this? Is it a formatting thing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, yeah, this was just word wrapping. When it is rendered as markdown, it'll all be one line that overflows.
Co-authored-by: Esther Kim <esthercodes2019@gmail.com>
Signed-off-by: Jesse Szwedko jesse.szwedko@datadoghq.com