Clean up and restructure files #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drarig29
commented
Aug 19, 2022
datadog-ci/package.json
Outdated
| "test": "jest" | ||
| "lint": "eslint **/*.ts", | ||
| "test": "jest", | ||
| "prepackage": "yarn install --production", |
There was a problem hiding this comment.
We must use yarn install --production not only to reduce the VSIX file from 55mb to 25mb but also because without this, we have an fsevents binary file and uploading the file fails because of a wrong MIME type (microsoft/tfs-cli#414).
Drarig29
commented
Aug 19, 2022
Drarig29
commented
Aug 19, 2022
Drarig29
commented
Aug 19, 2022
Drarig29
commented
Aug 19, 2022
Drarig29
commented
Aug 19, 2022
alai97
approved these changes
Aug 19, 2022
lefebvree
reviewed
Aug 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Azure DevOps tasks need a specific structure. Having it different complicates a lot of things.
The
node_modulesmust be included at the same level as thetask.jsonfile, in a subfolder for the task (that I calleddatadog-ci).Compiled
*.jsfiles must me at the same level as thetask.jsonfile, so we can't have adistfolder. When unit testing, we'll also need the compiled*.jsfiles to be at the same level as the*.tsfiles (proper unit testing will be added in a subsequent PR).