Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DDO-3972] Stop sending perf test notifications to #dsde-qa #402

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

choover-broad
Copy link
Contributor

@choover-broad choover-broad commented Jan 9, 2025

It looks like a recent PR (#398) had the side effect of reenabling Buffer's nightly perf tests, but they no longer work. I'd like to remove notifications to the #dsde-qa channel since it is used for monolith release triage and these are not release-blocking. Notifications will continue to go to other configured Slack channels.

@choover-broad choover-broad requested a review from a team as a code owner January 9, 2025 14:28
@choover-broad choover-broad requested review from kevinpalis and marctalbott and removed request for a team January 9, 2025 14:28
Copy link

sonarqubecloud bot commented Jan 9, 2025

@marctalbott
Copy link
Member

I went ahead and disabled the workflow (didn't realize it had started up again so thanks for the head's up!).

This is still worth merging IMO in case we accidentally re-enable it in the future.

@choover-broad choover-broad enabled auto-merge (squash) January 9, 2025 15:51
@choover-broad choover-broad disabled auto-merge January 9, 2025 15:51
@choover-broad choover-broad merged commit 6d86797 into master Jan 9, 2025
6 checks passed
@choover-broad choover-broad deleted the ch-DDO-3972 branch January 9, 2025 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants