[DCJ-473] Update db-connect.sh script
#1731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fboulnois
requested review from
rushtong and
okotsopoulos
and removed request for
a team
fboulnois
force-pushed
the
fb-dcj-473-refactor-db-connect-use-gsm
branch
4 times, most recently
from
c383809 to
6d86cce
Compare
rushtong
approved these changes
Jul 11, 2024
fboulnois
force-pushed
the
fb-dcj-473-refactor-db-connect-use-gsm
branch
from
cb6a570 to
247a760
Compare
fboulnois
force-pushed
the
fb-dcj-473-refactor-db-connect-use-gsm
branch
from
aa16b0b to
4d9048e
Compare
okotsopoulos
approved these changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses
https://broadworkbench.atlassian.net/browse/DCJ-473
Summary of changes
This is an overhaul of the
db-connect.shscript. The main change is the switch from Vault to Google Secrets Manager and to connect using a forwarded kubectl SQL proxy.Testing Strategy
Manual testing.