Skip to content

Commit

Permalink
Add additional TPS contract tests
Browse files Browse the repository at this point in the history
  • Loading branch information
@samanehsan
samanehsan committed Jan 22, 2024
1 parent 0ae774d commit b8cdff3
Showing 1 changed file with 152 additions and 41 deletions.
193 changes: 152 additions & 41 deletions src/test/java/bio/terra/pact/consumer/TpsPactTest.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
import static org.mockito.Mockito.when;

import au.com.dius.pact.consumer.MockServer;
import au.com.dius.pact.consumer.dsl.DslPart;
import au.com.dius.pact.consumer.dsl.PactDslWithProvider;
import au.com.dius.pact.consumer.junit5.PactConsumerTest;
import au.com.dius.pact.consumer.junit5.PactConsumerTestExt;
Expand All @@ -19,6 +20,7 @@
import bio.terra.policy.model.TpsComponent;
import bio.terra.policy.model.TpsObjectType;
import bio.terra.policy.model.TpsPaoCreateRequest;
import bio.terra.policy.model.TpsPaoUpdateRequest;
import bio.terra.policy.model.TpsPolicyInput;
import bio.terra.policy.model.TpsPolicyInputs;
import bio.terra.service.policy.PolicyApiService;
Expand All @@ -32,23 +34,85 @@
import org.springframework.test.context.ActiveProfiles;

@Tag("pact-test")
// @Tag(bio.terra.common.category.Pact.TAG)
@PactConsumerTest
@ActiveProfiles(bio.terra.common.category.Pact.PROFILE)
@ExtendWith(PactConsumerTestExt.class)
@PactTestFor(providerName = "tps", pactVersion = PactSpecVersion.V3)
class TpsPactTest {

private TpsApi tps;
private final UUID snapshotId = UUID.randomUUID();
private final TpsPolicyInput protectedDataPolicy =
new TpsPolicyInput()
.namespace(PolicyService.POLICY_NAMESPACE)
.name(PolicyService.PROTECTED_DATA_POLICY_NAME);
private final TpsPolicyInputs policies = new TpsPolicyInputs().addInputsItem(protectedDataPolicy);

TpsPaoCreateRequest createPAORequest =
new TpsPaoCreateRequest()
.objectId(snapshotId)
.component(TpsComponent.TDR)
.objectType(TpsObjectType.SNAPSHOT)
.attributes(new TpsPolicyInputs().addInputsItem(protectedDataPolicy));

private final String groupName = "testGroup";
private final TpsPolicyInput groupConstraintPolicy =
PolicyService.getGroupConstraintPolicyInput(groupName);
TpsPaoUpdateRequest updatePAORequest =
new TpsPaoUpdateRequest()
.updateMode(PolicyService.UPDATE_MODE)
.addAttributes(new TpsPolicyInputs().addInputsItem(groupConstraintPolicy));

static Map<String, String> contentTypeJsonHeader = Map.of("Content-Type", "application/json");

DslPart createPaoJsonBody =
newJsonBody(
object -> {
object.stringType("objectId", snapshotId.toString());
object.stringType("component", TpsComponent.TDR.getValue());
object.stringType("objectType", TpsObjectType.SNAPSHOT.getValue());
object.object(
"attributes",
(attributes) ->
attributes.array(
"inputs",
(inputs) ->
inputs.object(
i -> {
i.stringType("namespace", PolicyService.POLICY_NAMESPACE);
i.stringType(
"name", PolicyService.PROTECTED_DATA_POLICY_NAME);
})));
})
.build();

DslPart updatePaoJsonBody =
newJsonBody(
object -> {
object.stringType("updateMode", PolicyService.UPDATE_MODE.getValue());
object.object(
"addAttributes",
(attributes) ->
attributes.array(
"inputs",
(inputs) ->
inputs.object(
i -> {
i.stringType("namespace", PolicyService.POLICY_NAMESPACE);
i.stringType(
"name", PolicyService.GROUP_CONSTRAINT_POLICY_NAME);
i.array(
"additionalData",
(additionalData) ->
additionalData.object(
data -> {
data.stringType(
"key",
PolicyService.GROUP_CONSTRAINT_KEY_NAME);
data.stringType("value", "testGroup");
}));
})));
})
.build();

@BeforeEach
void setup(MockServer mockServer) throws Exception {
var tpsConfig = mock(PolicyServiceConfiguration.class);
Expand All @@ -60,43 +124,77 @@ void setup(MockServer mockServer) throws Exception {

@Pact(consumer = "datarepo")
RequestResponsePact createPao(PactDslWithProvider builder) {
String snapshotId = UUID.randomUUID().toString();
return builder
.given("default")
.given("a PAO with this id does not exist")
.uponReceiving("create PAO for TDR snapshot")
.method("POST")
.path("/api/policy/v1alpha1/pao")
.body(
newJsonBody(
object -> {
object.stringType("objectId", snapshotId);
object.stringType("component", TpsComponent.TDR.getValue());
object.stringType("objectType", TpsObjectType.SNAPSHOT.getValue());
object.object(
"attributes",
(attributes) ->
attributes.array(
"inputs",
(inputs) ->
inputs.object(
i -> {
i.stringType(
"namespace", PolicyService.POLICY_NAMESPACE);
i.stringType(
"name", PolicyService.PROTECTED_DATA_POLICY_NAME);
})));
})
.build())
.body(createPaoJsonBody)
.headers(contentTypeJsonHeader)
.willRespondWith()
.status(204)
.toPact();
}

@Pact(consumer = "datarepo")
RequestResponsePact createPaoConflict(PactDslWithProvider builder) {
return builder
.given("a PAO with this id exists")
.uponReceiving("create PAO for TDR snapshot throws conflict error")
.method("POST")
.path("/api/policy/v1alpha1/pao")
.body(createPaoJsonBody)
.headers(contentTypeJsonHeader)
.willRespondWith()
.status(409)
.toPact();
}

@Pact(consumer = "datarepo")
RequestResponsePact updatePao(PactDslWithProvider builder) {
return builder
.given("a PAO with a protected-data policy exists for this snapshot")
.uponReceiving("update snapshot PAO with group constraint policy")
.method("PATCH")
.path("/api/policy/v1alpha1/pao/" + snapshotId)
.body(updatePaoJsonBody)
.headers(contentTypeJsonHeader)
.willRespondWith()
.status(200)
.headers(contentTypeJsonHeader)
.toPact();
}

@Pact(consumer = "datarepo")
RequestResponsePact updatePaoConflict(PactDslWithProvider builder) {
return builder
.given("a PAO with a group constraint policy exists for this snapshot")
.uponReceiving("update snapshot PAO with duplicate group constraint policy")
.method("PATCH")
.path("/api/policy/v1alpha1/pao/" + snapshotId)
.body(updatePaoJsonBody)
.headers(contentTypeJsonHeader)
.willRespondWith()
.status(409)
.toPact();
}

@Pact(consumer = "datarepo")
RequestResponsePact deletePao(PactDslWithProvider builder) {
return builder
.given("a PAO with this id exists")
.uponReceiving("delete PAO")
.method("DELETE")
.path("/api/policy/v1alpha1/pao/" + snapshotId)
.willRespondWith()
.status(200)
.toPact();
}

@Pact(consumer = "datarepo")
RequestResponsePact deletePaoThatDoesNotExist(PactDslWithProvider builder) {
return builder
.given("default")
.given("a PAO with this id does not exist")
.uponReceiving("delete non-existent PAO")
.method("DELETE")
.path("/api/policy/v1alpha1/pao/" + snapshotId)
Expand All @@ -105,29 +203,42 @@ RequestResponsePact deletePaoThatDoesNotExist(PactDslWithProvider builder) {
.toPact();
}

// create snapshot protected data policy - success
@Test
@PactTestFor(pactMethod = "createPao")
void createPaoSuccess(MockServer mockServer) throws ApiException {
// call createPao with the snapshot id
tps.createPao(
new TpsPaoCreateRequest()
.objectId(snapshotId)
.component(TpsComponent.TDR)
.objectType(TpsObjectType.SNAPSHOT)
.attributes(policies));
tps.createPao(createPAORequest);
}

// create snapshot group policy - success
@Test
@PactTestFor(pactMethod = "createPaoConflict")
void createPaoConflictError(MockServer mockServer) throws ApiException {
assertThrows(
ApiException.class,
() -> tps.createPao(createPAORequest),
"creating a policy should return 409 if one already exists");
}

// create snapshot policy -- conflict error
@Test
@PactTestFor(pactMethod = "updatePao")
void updatePaoSuccess(MockServer mockServer) throws ApiException {
tps.updatePao(updatePAORequest, snapshotId);
}

// update existing policy (already protected data, update with group policy)
// state requires policy with this id to already exist
@Test
@PactTestFor(pactMethod = "updatePaoConflict")
void updatePaoWithDuplicatePolicy(MockServer mockServer) {
assertThrows(
ApiException.class,
() -> tps.updatePao(updatePAORequest, snapshotId),
"updating pao with duplicate policy should return 409");
}

// delete a policy (exists - requires TPS state to have this policy)
@Test
@PactTestFor(pactMethod = "deletePao")
void deletePaoSuccess(MockServer mockServer) throws ApiException {
tps.deletePao(snapshotId);
}

// delete a policy (does not exist)
@Test
@PactTestFor(pactMethod = "deletePaoThatDoesNotExist")
void deletePaoThatDoesNotExist(MockServer mockServer) {
Expand Down

0 comments on commit b8cdff3

Please sign in to comment.