Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DT-295] Remove unused CRA packages #2782

Merged
merged 3 commits into from
Feb 14, 2025
Merged

Conversation

fboulnois
Copy link
Contributor

@fboulnois fboulnois commented Feb 13, 2025

Addresses

https://broadworkbench.atlassian.net/browse/DT-295

Summary

Follow up to #2783 . These packages no longer need to be pinned / are no longer used.


Have you read Terra's Contributing Guide lately? If not, do that first.

  • Label PR with a Jira ticket number and include a link to the ticket
  • Label PR with a security risk modifier [no, low, medium, high]
  • PR describes scope of changes
  • Get a minimum of one thumbs worth of review, preferably two if enough team members are available
  • Get PO sign-off for all non-trivial UI or workflow changes
  • Verify all tests go green
  • Test this change deployed correctly and works on dev environment after deployment

@fboulnois fboulnois marked this pull request as ready for review February 13, 2025 18:16
@fboulnois fboulnois requested a review from a team as a code owner February 13, 2025 18:16
@fboulnois fboulnois requested review from rushtong and snf2ye and removed request for a team February 13, 2025 18:16
Copy link
Contributor

@rushtong rushtong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

"google-auth-library": "9.15.1",
"globals": "15.14.0",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is now required for eslint 9

otherwise the tests do not execute
@fboulnois fboulnois force-pushed the fb-dt-295-vite-package-cleanup branch from 36d8ee4 to 4d9c508 Compare February 14, 2025 00:33
@fboulnois fboulnois force-pushed the fb-dt-295-vite-package-cleanup branch from 4d9c508 to dab4c54 Compare February 14, 2025 00:40
@fboulnois fboulnois changed the base branch from develop to fb-dt-295-fix-cypress-https February 14, 2025 00:40
Base automatically changed from fb-dt-295-fix-cypress-https to develop February 14, 2025 15:00
@fboulnois fboulnois merged commit 3222369 into develop Feb 14, 2025
9 checks passed
@fboulnois fboulnois deleted the fb-dt-295-vite-package-cleanup branch February 14, 2025 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants