[DT-1081] Fix filter bugs #2754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s-rubenstein
requested review from
rushtong and
fboulnois
and removed request for
a team
rushtong
reviewed
Dec 11, 2024
| const filterHandlerStub = cy.stub(); | ||
| const props = { datasets, filters: { ...defaultFilters(datasets), participantCountMin: 2, participantCountMax: 5 }, filterHandler: filterHandlerStub, isFiltered: () => {}}; | ||
| mount(<DatasetFilterList {...props} />); | ||
| cy.get('#participantCountMax-range-input').type('3').trigger('change'); |
There was a problem hiding this comment.
Chaining calls after type is unsafe. A lot of our tests suffer from this pattern, so it is something we should be trying to clean up.
rushtong
reviewed
Dec 11, 2024
| @@ -303,7 +293,7 @@ export const DatasetSearchTable = (props) => { | |||
| </Box> | |||
| <Box sx={{display: 'flex', flexDirection: 'row', paddingTop: '2em'}}> | |||
| <Box sx={{width: '14%', padding: '0 1em'}}> | |||
| <DatasetFilterList datasets={datasets} filterHandler={filterHandler} isFiltered={isFilteredArray} onClear={() => setFilters(defaultFilters)}/> | |||
| <DatasetFilterList datasets={datasets} filterHandler={filterHandler} filters={filters} isFiltered={isFilteredArray} onClear={() => setFilters(defaultFilters(datasets))}/> | |||
There was a problem hiding this comment.
Something about this is breaking the dataset_search_table.spec.js tests, but it's not exactly clear what. I think the tests might be a little brittle as well in that they're expecting a populated response.response.body[0] object.
There was a problem hiding this comment.
I think I see it. The search filter text is slightly different in this PR which breaks the test. Changing line 68 in dataset_search_table.spec.js to:
return handler(req, '{"range":{"participantCount":{"gte":100,"lte":"50"}}}');
and line 91 to
return handler(req, '{"range":{"participantCount":{"gte":100,"lte":100}}}');
allows the string matching in the handler function to work correctly.
rushtong
approved these changes
Dec 11, 2024
fboulnois
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses
Summary
Have you read Terra's Contributing Guide lately? If not, do that first.