Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DT-252][risk=no] Refactor user properties #2567

Merged
merged 6 commits into from
Feb 24, 2025

Conversation

rushtong
Copy link
Contributor

@rushtong rushtong commented May 5, 2024

Addresses

https://broadworkbench.atlassian.net/browse/DT-252

Summary

Refactor usages of researcherProperties to be properties

Requires DataBiosphere/consent#2322


Have you read Terra's Contributing Guide lately? If not, do that first.

  • Label PR with a Jira ticket number and include a link to the ticket
  • Label PR with a security risk modifier [no, low, medium, high]
  • PR describes scope of changes
  • Get a minimum of one thumbs worth of review, preferably two if enough team members are available
  • Get PO sign-off for all non-trivial UI or workflow changes
  • Verify all tests go green
  • Test this change deployed correctly and works on dev environment after deployment

@rushtong rushtong changed the title [DCJ-252][risk=no] Refactor user properties [DT-252][risk=no] Refactor user properties Feb 18, 2025
@rushtong rushtong marked this pull request as ready for review February 19, 2025 12:43
@rushtong rushtong requested a review from a team as a code owner February 19, 2025 12:43
@rushtong rushtong requested review from pshapiro4broad and fboulnois and removed request for a team February 19, 2025 12:43
Copy link
Contributor

@fboulnois fboulnois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 👍

@rushtong rushtong merged commit 744f90f into develop Feb 24, 2025
9 checks passed
@rushtong rushtong deleted the gr-DCJ-252-refactor-user-props branch February 24, 2025 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants