Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DT-252][risk=no] Refactor user properties #2322

Merged
merged 6 commits into from
Feb 24, 2025
Merged

[DT-252][risk=no] Refactor user properties #2322

merged 6 commits into from
Feb 24, 2025

Conversation

rushtong
Copy link
Contributor

@rushtong rushtong commented May 5, 2024 •
edited
Loading

Addresses

https://broadworkbench.atlassian.net/browse/DT-252

Summary

  • Refactor usages of researcherProperties to be properties
  • Consolidates the usages of ResearcherService methods into NihService since that was the only place ResearcherService was used.
  • Expanded tests for NihService

Requires DataBiosphere/duos-ui#2567

Have you read CONTRIBUTING.md lately? If not, do that first.

  • Label PR with a Jira ticket number and include a link to the ticket
  • Label PR with a security risk modifier [no, low, medium, high]
  • PR describes scope of changes
  • Get a minimum of one thumbs worth of review, preferably two if enough team members are available
  • Get PO sign-off for all non-trivial UI or workflow changes
  • Verify all tests go green
  • Test this change deployed correctly and works on dev environment after deployment

@rushtong rushtong mentioned this pull request May 5, 2024
Merged
rushtong added 5 commits May 17, 2024 10:30
@rushtong
Merge branch 'refs/heads/develop' into gr-DCJ-252-refactor-user-prope…
d2c0a3c 
…rties-field
@rushtong
Merge branch 'refs/heads/develop' into gr-DCJ-252-refactor-user-prope…
dee52c4 
…rties-field

# Conflicts:
#	src/main/java/org/broadinstitute/consent/http/db/UserPropertyDAO.java
#	src/main/java/org/broadinstitute/consent/http/service/UserService.java
#	src/test/java/org/broadinstitute/consent/http/service/UserServiceTest.java
@rushtong
feat: merge fixes
e758e0b
@rushtong
feat: clean up researcher service
1927cf1
@rushtong
feat: clean up raw typing and unused method
39825ac
@rushtong rushtong changed the title [DCJ-252][risk=no] Refactor user properties [DT-252][risk=no] Refactor user properties Feb 18, 2025
@rushtong rushtong marked this pull request as ready for review February 19, 2025 12:43
@rushtong rushtong requested a review from a team as a code owner February 19, 2025 12:43
@rushtong rushtong requested review from snf2ye and s-rubenstein and removed request for a team February 19, 2025 12:43
s-rubenstein
s-rubenstein approved these changes Feb 20, 2025
View reviewed changes
Copy link

@s-rubenstein s-rubenstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable! I don't know if I fully understand the context, but nothing here throws up any red flags for me.

@rushtong rushtong merged commit 090ff29 into develop Feb 24, 2025
14 checks passed
@rushtong rushtong deleted the gr-DCJ-252-refactor-user-properties-field branch February 24, 2025 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snf2ye snf2ye snf2ye approved these changes

@s-rubenstein s-rubenstein s-rubenstein approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rushtong @snf2ye @s-rubenstein