Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V5x0 mtl charging #67

Merged
merged 1 commit into from
Feb 28, 2025
Merged

V5x0 mtl charging #67

merged 1 commit into from
Feb 28, 2025

Conversation

wiktormowinski
Copy link

No description provided.

@wiktormowinski wiktormowinski marked this pull request as draft February 25, 2025 13:08
Copy link
Member

@mkopec mkopec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks about right now, let's test on hardware to see if this fixes the problem.

Please also squash the commits and update the commit message, maybe something like this

board/system76/common/acpi.c: Fix battery charge status logic

Signed-off-by: Wiktor Mowinski <wiktor.mowinski@3mdeb.com>

board/system76/common/acpi.c: Fix battery charge status logic

Signed-off-by: Wiktor Mowinski <wiktor.mowinski@3mdeb.com>
@mkopec
Copy link
Member

mkopec commented Feb 28, 2025

Should this still be a draft @wiktormowinski ?

mkopec
mkopec approved these changes Feb 28, 2025
@mkopec mkopec merged commit 4659f15 into master Feb 28, 2025
3 of 9 checks passed
@miczyg1 miczyg1 deleted the v5x0_mtl_charging branch March 6, 2025 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants