Vp2430 new rev #627
Merged
Vp2430 new rev #627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macpijan
reviewed
Mar 5, 2025
macpijan
approved these changes
Mar 5, 2025
mkopec
approved these changes
Mar 10, 2025
IDs taken from ADL-N and TWL EDS Vol 1 Rev 2.5 doc #645548. Upstream-Status: https://review.coreboot.org/c/coreboot/+/86750 Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
Serial ports have been swapped on newer revision of VP2430. There is no need to swap the I/O ports anymore in coreboot. Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
…ating UPDs" This reverts commit 491afc3. Reason for revert: Starting with FSP MR6, the 'PchPcieClockGating' and 'PchPciePowerGating' UPDs are also available on ADL-N. Change-Id: I0134737cfb956163ea6e722cd0a3f39dffbaa13b Signed-off-by: Filip Brozovic <fbrozovic@gmail.com>
The newest IoT FSPs have the PchPciePowerGating and PchPcieClockGating UPDs present. There is no need to guard it against custom FSP for one platform. Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TEST=Boot Ubuntu 22.04 live on the new VP2430 revision. All displays work, tested HDMI, DP and both USB-C ports with Dell monitors.