Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Charging issue #623

Merged
merged 1 commit into from
Feb 28, 2025
Merged

Charging issue #623

merged 1 commit into from
Feb 28, 2025

Conversation

wiktormowinski
Copy link
Contributor

this PR aims to resolve an issue regarding false prompts indicating battery charging status

@wiktormowinski wiktormowinski force-pushed the v5x0_mtl_charging branch 2 times, most recently from 6ed84ff to 81a1e08 Compare February 25, 2025 16:22
@mkopec
Copy link
Member

mkopec commented Feb 26, 2025

Code change looks good, have you tested if it fixes the issue when combined with your ec change?

Copy link
Member

@mkopec mkopec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: depends on Dasharo/ec#67

@mkopec mkopec force-pushed the v5x0_mtl_charging branch 2 times, most recently from a9152e5 to d175b8c Compare February 28, 2025 11:55
Skip redundant logic in ACPI and trust what the EC says.

Signed-off-by: Wiktor Mowinski <wiktor.mowinski@3mdeb.com>
Signed-off-by: Michał Kopeć <michal.kopec@3mdeb.com>
@mkopec mkopec merged commit 5d6e2f9 into dasharo Feb 28, 2025
4 of 5 checks passed
@mkopec mkopec deleted the v5x0_mtl_charging branch February 28, 2025 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants