Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrupted zip file result in zipToS3File #39

Open
SeanoNET opened this issue Dec 5, 2019 · 0 comments
Open

Corrupted zip file result in zipToS3File #39

SeanoNET opened this issue Dec 5, 2019 · 0 comments

Comments

@SeanoNET
Copy link

SeanoNET commented Dec 5, 2019

Hi Daniel,

I was getting corrupted zip files when using the aws-s3-zipper@1.3.0 with archiver version 0.21.*. The S3 bucket had around 3,500 images at about 1.8 KB each. I did not experience this on buckets with a small amount of images.

zipper.filterOutFiles = function(file){
				if(file.Key.indexOf('.zip') >= 0) // filter out zip files
					return null;
				else 
				  return file;
};
		  
zipper.zipToS3File({s3FolderName: `test`, s3ZipFileName: `test/export.zip`},(err,result)=>{
	if(err)
		reject(err);
	else{
		console.log(`Done: ${result}`);                                       
	}
});

After upgrading to the latest version aws-s3-zipper@1.3.1 (This is not on npm) and updating archiver to 3.1.1, i was no longer getting corrupted zip files.

Can we please upgrade the archive version to 3.1.1, forgive my ignorance - I am not sure if/what this will break in aws-s3-zipper as this is a 3 major version upgrade.

https://github.com/DanielHindi/aws-s3-zipper/blob/master/package.json#L7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant